Skip to content

SK-2502 fix the request and response in connections #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skyflow-bharti merged 6 commits into from
Feb 6, 2026
Merged

SK-2502 fix the request and response in connections #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2eb2c36
SK-2502 fix the request and response in connections
skyflow-bharti Feb 5, 2026
5346898
SK-2502 fix the request and response in connections
skyflow-bharti Feb 5, 2026
e573d88
SK-2502 close response in connections
skyflow-bharti Feb 6, 2026
4529001
SK-2541 fix the test
skyflow-bharti Feb 6, 2026
94d8282
Merge branch 'release/26.1.5' into SK-2502-Fix-go-sdk-v2-issues
skyflow-bharti Feb 6, 2026
91781f2
SK-2541 resolve the comment
skyflow-bharti Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions v2/client/service_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1361,12 +1361,12 @@ var _ = Describe("ConnectionController", func() {
mockServer *httptest.Server
//mockToken string
mockRequest InvokeConnectionRequest
mockResponse map[string]interface{}
//mockResponse map[string]interface{}
)

BeforeEach(func() {
//mockToken = "mock-valid-token"
mockResponse = map[string]interface{}{"key": "value"}
//mockResponse = map[string]interface{}{"key": "value"}
mockRequest = InvokeConnectionRequest{
Headers: map[string]string{
"Content-Type": "application/json",
Expand Down Expand Up @@ -1405,7 +1405,7 @@ var _ = Describe("ConnectionController", func() {
service, err := client.Connection("failed")
response, err := service.Invoke(ctx, mockRequest)
Expect(err).To(BeNil())
Expect(response.Data).To(Equal(mockResponse))
Expect(response.Data).To(Equal(fmt.Sprintf("%v", `{"key": "value"}`)))
})
})
Context("Handling query parameters", func() {
Expand Down
9 changes: 6 additions & 3 deletions v2/internal/validation/validations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,9 +645,12 @@ func ValidateInvokeConnectionRequest(request common.InvokeConnectionRequest) *sk
}
// Validate body
if request.Body != nil {
if len(request.Body) == 0 {
logger.Error(fmt.Sprintf(logs.EMPTY_REQUEST_BODY, constants.REQUEST_INVOKE_CONNECTION))
return skyflowError.NewSkyflowError(skyflowError.INVALID_INPUT_CODE, skyflowError.EMPTY_REQUEST_BODY)
// Check if body is a map and if it's empty
if bodyMap, ok := request.Body.(map[string]interface{}); ok {
if len(bodyMap) == 0 {
logger.Error(fmt.Sprintf(logs.EMPTY_REQUEST_BODY, constants.REQUEST_INVOKE_CONNECTION))
return skyflowError.NewSkyflowError(skyflowError.INVALID_INPUT_CODE, skyflowError.EMPTY_REQUEST_BODY)
}
}
}
if request.Method != "" {
Expand Down
Loading
Loading