SK-2502 fix the request and response in connections#165
SK-2502 fix the request and response in connections#165skyflow-bharti merged 6 commits intorelease/26.1.5from
Conversation
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
|
GoSec Findings: No issues found, Good to merge. |
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
|
GoSec Findings: No issues found, Good to merge. |
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
|
GoSec Findings: No issues found, Good to merge. |
There was a problem hiding this comment.
Pull request overview
Updates the connection invocation flow to support multiple request/response content types (JSON, XML, urlencoded, multipart, text).
Changes:
- Generalize
InvokeConnectionRequest.BodyandInvokeConnectionResponse.Datatointerface{}to allow non-JSON payloads. - Add request serialization + response parsing for XML, urlencoded, multipart, and text content types.
- Extend controller tests to cover many content-type/body combinations and parsing behaviors.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| v2/utils/messages/info_logs.go | Adjusts bearer-token expired log message text. |
| v2/utils/messages/error_logs.go | Adds an “invalid XML format” log constant. |
| v2/utils/error/message.go | Adds an “invalid XML format” SDK error message constant. |
| v2/utils/common/common.go | Loosens request/response payload types and adds content-type enums. |
| v2/internal/vault/controller/connection_controller.go | Implements multi-content-type request build + response parse logic. |
| v2/internal/validation/validations.go | Updates validation to handle non-map request bodies. |
| v2/internal/vault/controller/controller_test.go | Adds extensive test coverage for new content-type handling. |
| v2/client/service_test.go | Updates expectations for connection invoke response behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
de40b5f to
4529001
Compare
Why:
Connections should be able to handle different type of request and response content type