Skip to content

SK-2502 fix the request and response in connections#165

Merged
skyflow-bharti merged 6 commits intorelease/26.1.5from
SK-2502-Fix-go-sdk-v2-issues
Feb 6, 2026
Merged

SK-2502 fix the request and response in connections#165
skyflow-bharti merged 6 commits intorelease/26.1.5from
SK-2502-Fix-go-sdk-v2-issues

Conversation

@skyflow-bharti
Copy link
Collaborator

@skyflow-bharti skyflow-bharti commented Feb 5, 2026

Why:
Connections should be able to handle different type of request and response content type

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Gitleaks Findings: No secrets detected. Safe to proceed!

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging.

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

GoSec Findings: No issues found, Good to merge.

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Gitleaks Findings: No secrets detected. Safe to proceed!

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging.

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

GoSec Findings: No issues found, Good to merge.

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Gitleaks Findings: No secrets detected. Safe to proceed!

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging.

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

GoSec Findings: No issues found, Good to merge.

@skyflow-bharti skyflow-bharti changed the base branch from main to release/26.1.5 February 6, 2026 12:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the connection invocation flow to support multiple request/response content types (JSON, XML, urlencoded, multipart, text).

Changes:

  • Generalize InvokeConnectionRequest.Body and InvokeConnectionResponse.Data to interface{} to allow non-JSON payloads.
  • Add request serialization + response parsing for XML, urlencoded, multipart, and text content types.
  • Extend controller tests to cover many content-type/body combinations and parsing behaviors.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
v2/utils/messages/info_logs.go Adjusts bearer-token expired log message text.
v2/utils/messages/error_logs.go Adds an “invalid XML format” log constant.
v2/utils/error/message.go Adds an “invalid XML format” SDK error message constant.
v2/utils/common/common.go Loosens request/response payload types and adds content-type enums.
v2/internal/vault/controller/connection_controller.go Implements multi-content-type request build + response parse logic.
v2/internal/validation/validations.go Updates validation to handle non-map request bodies.
v2/internal/vault/controller/controller_test.go Adds extensive test coverage for new content-type handling.
v2/client/service_test.go Updates expectations for connection invoke response behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@skyflow-bharti skyflow-bharti force-pushed the SK-2502-Fix-go-sdk-v2-issues branch from de40b5f to 4529001 Compare February 6, 2026 12:57
@skyflow-bharti skyflow-bharti merged commit 56a4f75 into release/26.1.5 Feb 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments