fix(bullmq): restore CONCURRENCY_CONTROL_ENABLED flag guard#3903
fix(bullmq): restore CONCURRENCY_CONTROL_ENABLED flag guard#3903waleedlatif1 merged 1 commit intostagingfrom
Conversation
PR SummaryMedium Risk Overview
Written by Cursor Bugbot for commit b04438e. Configure here. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile SummaryThis PR is a targeted bug fix that restores the Key changes:
The fix is minimal and correct. Confidence Score: 5/5This PR is safe to merge — it is a minimal, focused revert of a regression with no new logic introduced. The change touches exactly two lines of logic: restoring a deleted env var declaration and adding back a single boolean guard. The fix is straightforwardly correct, the default of 'false' ensures safe opt-out, and the isTruthy helper already handles the string-boolean edge case. No API surface, schema, or behavioral contract changes are introduced. No findings were raised. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["isBullMQEnabled()"] --> B{"CONCURRENCY_CONTROL_ENABLED\n== 'true' or '1'?"}
B -- "No (default: 'false')" --> C["return false\n→ Inline / direct execution"]
B -- "Yes" --> D{"REDIS_URL set?"}
D -- "No" --> C
D -- "Yes" --> E["return true\n→ BullMQ queue-based execution"]
style C fill:#f87171,color:#fff
style E fill:#4ade80,color:#000
Reviews (1): Last reviewed commit: "fix(bullmq): restore CONCURRENCY_CONTROL..." | Re-trigger Greptile |
Summary
CONCURRENCY_CONTROL_ENABLEDenv var that was accidentally removed in df6ceb6isBullMQEnabled()was changed to returntruewheneverREDIS_URLis set, which enabled BullMQ in prod without the feature flag — breaking Slack-triggered workflow executionisBullMQEnabled()to require bothCONCURRENCY_CONTROL_ENABLED=trueANDREDIS_URLType of Change
Testing
Tested manually
Checklist