Skip to content

v0.6.21: concurrency FF, blog theme#3904

Merged
waleedlatif1 merged 2 commits intomainfrom
staging
Apr 2, 2026
Merged

v0.6.21: concurrency FF, blog theme#3904
waleedlatif1 merged 2 commits intomainfrom
staging

Conversation

@waleedlatif1
Copy link
Copy Markdown
Collaborator

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Apr 2, 2026 8:08pm

Request Review

@cursor
Copy link
Copy Markdown

cursor bot commented Apr 2, 2026

PR Summary

Medium Risk
Changes when BullMQ is considered enabled by adding a new CONCURRENCY_CONTROL_ENABLED flag check, which can alter runtime execution/concurrency behavior depending on env configuration. Remaining changes are limited to blog MDX styling variables.

Overview
Restores feature-flag gating for BullMQ-based concurrency control. isBullMQEnabled() now requires both REDIS_URL and CONCURRENCY_CONTROL_ENABLED to be truthy, and the env schema adds CONCURRENCY_CONTROL_ENABLED (default false).

Aligns blog MDX styling with landing theme variables. Updates paragraph/list text colors and inline code background to use --landing-* CSS variables instead of the previous theme tokens.

Written by Cursor Bugbot for commit 727bb1c. Configure here.

@waleedlatif1 waleedlatif1 merged commit f0d1950 into main Apr 2, 2026
14 checks passed
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 2, 2026

Greptile Summary

This PR bundles two focused bug fixes: (1) aligns blog MDX components to use landing-page theme CSS variables (--landing-text-muted, --landing-bg-elevated) instead of app-scoped variables (--text-subtle, --surface-4) to ensure correct colors when blog pages are rendered under the landing theme; (2) restores the CONCURRENCY_CONTROL_ENABLED feature-flag guard in isBullMQEnabled(), preventing BullMQ from being silently activated solely by the presence of REDIS_URL.

  • mdx.tsx: Four CSS variable references updated — p, ul, and ol text color fixed from --text-subtle--landing-text-muted; inline code background fixed from --surface-4--landing-bg-elevated. All MDX element theme tokens are now consistently sourced from the landing theme.
  • connection.ts: isBullMQEnabled() now returns isTruthy(env.CONCURRENCY_CONTROL_ENABLED) && Boolean(env.REDIS_URL), requiring an explicit CONCURRENCY_CONTROL_ENABLED=true in addition to REDIS_URL.
  • env.ts: Declares CONCURRENCY_CONTROL_ENABLED as z.string().optional().default('false') — safe default that keeps BullMQ opt-in and leverages the existing isTruthy helper correctly.

Confidence Score: 5/5

Safe to merge — changes are minimal, targeted, and correct with no regressions introduced.

No P0 or P1 issues found. All three files make precise, low-risk changes: CSS variable renames in a presentational file, a feature-flag guard restore, and a matching env var declaration. Logic and types are consistent throughout.

No files require special attention.

Important Files Changed

Filename Overview
apps/sim/lib/blog/mdx.tsx Replaces three app-scoped CSS variables (--text-subtle, --surface-4) with their landing-theme equivalents (--landing-text-muted, --landing-bg-elevated), making all MDX components consistently use landing-page theme tokens.
apps/sim/lib/core/bullmq/connection.ts Restores the CONCURRENCY_CONTROL_ENABLED feature-flag guard in isBullMQEnabled(), so BullMQ activation now requires an explicit opt-in env var in addition to REDIS_URL.
apps/sim/lib/core/config/env.ts Adds CONCURRENCY_CONTROL_ENABLED as an optional string env var defaulting to 'false', correctly typed for use with the existing isTruthy utility.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Request arrives] --> B{isBullMQEnabled?}
    B -- "CONCURRENCY_CONTROL_ENABLED=true AND REDIS_URL set" --> C[BullMQ / Concurrency Queue]
    B -- "CONCURRENCY_CONTROL_ENABLED=false OR REDIS_URL missing" --> D[Inline Execution]
    C --> E[Worker processes job]
    D --> F[Direct execution]
    E --> G[Response]
    F --> G
Loading

Reviews (1): Last reviewed commit: "fix(bullmq): restore CONCURRENCY_CONTROL..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant