Skip to content

FIX Update phpunit.xml.dist #11547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lekoala wants to merge 1 commit into
base: 5
Choose a base branch
from
Open

FIX Update phpunit.xml.dist #11547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,14 @@ Requires PHPUnit ^9
</testsuite>
<!-- Framework ORM tests are split up to run in parallel -->
<testsuite name="framework-core">
<directory>tests/php</directory>
<exclude>
<directory>tests/php/ORM</directory>
</exclude>
<directory>tests/php/Control</directory>
<directory>tests/php/Core</directory>
<directory>tests/php/Dev</directory>
<directory>tests/php/Forms</directory>
<directory>tests/php/i18n</directory>
<directory>tests/php/Logging</directory>
<directory>tests/php/Security</directory>
<directory>tests/php/View</directory>
Comment on lines -13 to +20
Copy link
Member

@GuySartorelli GuySartorelli Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explicitly listing each item isn't maintainable - we will innevitably forget to add new directories here when we create them.

Copy link
Contributor Author

@lekoala lekoala Jan 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then the other way is to move test files into one folder per test suite that can run in parallel

using "exclude" is not really maintainable either since it's deprecated

</testsuite>
<testsuite name="framework-orm">
<directory>tests/php/ORM</directory>
Expand All @@ -22,13 +26,13 @@ Requires PHPUnit ^9
<directory>vendor/silverstripe/cms/tests</directory>
</testsuite>
</testsuites>
<filter>
<whitelist addUncoveredFilesFromWhitelist="true">
<coverage>
<include>
<directory suffix=".php">.</directory>
<exclude>
<directory suffix=".php">tests/</directory>
<directory suffix=".php">thirdparty/</directory>
</exclude>
</whitelist>
</filter>
</include>
<exclude>
<directory suffix=".php">tests/</directory>
<directory suffix=".php">thirdparty/</directory>
</exclude>
</coverage>
</phpunit>
Loading