Skip to content

Conversation

@lekoala
Copy link
Contributor

@lekoala lekoala commented Jan 10, 2025

Description

Running tests currently give warnings. This seems fairly easy to fix so I did it :-)

Manual testing steps

No more warnings when running tests

Issues

#11546

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

Comment on lines -13 to +20
<directory>tests/php</directory>
<exclude>
<directory>tests/php/ORM</directory>
</exclude>
<directory>tests/php/Control</directory>
<directory>tests/php/Core</directory>
<directory>tests/php/Dev</directory>
<directory>tests/php/Forms</directory>
<directory>tests/php/i18n</directory>
<directory>tests/php/Logging</directory>
<directory>tests/php/Security</directory>
<directory>tests/php/View</directory>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explicitly listing each item isn't maintainable - we will innevitably forget to add new directories here when we create them.

Copy link
Contributor Author

@lekoala lekoala Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then the other way is to move test files into one folder per test suite that can run in parallel

using "exclude" is not really maintainable either since it's deprecated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants