Skip to content

refactor(datepicker): explicitly define change detection strategy #2199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spliffone wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(datepicker): explicitly define change detection strategy #2199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions projects/element-ng/datepicker/components/si-calendar-body.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import { A11yModule } from '@angular/cdk/a11y';
import {
booleanAttribute,
ChangeDetectionStrategy,
Component,
computed,
input,
Expand Down Expand Up @@ -141,6 +142,7 @@ class RangeSelectionStrategy extends SelectionStrategy {
selector: '[si-calendar-body]',
imports: [A11yModule, SiCalendarDateCellDirective],
templateUrl: './si-calendar-body.component.html',
changeDetection: ChangeDetectionStrategy.OnPush,
host: {
class: 'si-calendar-body'
},
Expand Down
4 changes: 3 additions & 1 deletion projects/element-ng/datepicker/components/si-initial-focus.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import {
AfterViewInit,
booleanAttribute,
ChangeDetectionStrategy,
Component,
input,
model,
Expand All @@ -19,7 +20,8 @@ import { Cell, SiCalendarBodyComponent } from './si-calendar-body.component';
* Helper directive to set the initial focus to the calendar body cell.
*/
@Component({
template: ''
template: '',
changeDetection: ChangeDetectionStrategy.OnPush
})
export class SiInitialFocusComponent implements AfterViewInit {
/** The cell which has the mouse hover. */
Expand Down
2 changes: 2 additions & 0 deletions projects/element-ng/datepicker/si-date-range.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { A11yModule } from '@angular/cdk/a11y';
import {
AfterViewInit,
booleanAttribute,
ChangeDetectionStrategy,
ChangeDetectorRef,
Component,
ComponentRef,
Expand Down Expand Up @@ -76,6 +77,7 @@ import { DatepickerInputConfig, DateRange } from './si-datepicker.model';
useExisting: SiDateRangeComponent
}
],
changeDetection: ChangeDetectionStrategy.Default,
host: {
class: 'form-control d-flex align-items-center',
role: 'group',
Expand Down
4 changes: 3 additions & 1 deletion projects/element-ng/datepicker/si-datepicker.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { getLocaleFirstDayOfWeek, WeekDay } from '@angular/common';
import {
AfterViewInit,
booleanAttribute,
ChangeDetectionStrategy,
ChangeDetectorRef,
Component,
computed,
Expand Down Expand Up @@ -69,7 +70,8 @@ export type RangeType = 'START' | 'END' | undefined;
SiTranslatePipe
],
templateUrl: './si-datepicker.component.html',
styleUrl: './si-datepicker.component.scss'
styleUrl: './si-datepicker.component.scss',
changeDetection: ChangeDetectionStrategy.Default
})
export class SiDatepickerComponent implements OnInit, OnChanges, AfterViewInit {
private readonly locale = inject(LOCALE_ID).toString();
Expand Down
5 changes: 3 additions & 2 deletions projects/element-ng/datepicker/si-timepicker.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* Copyright (c) Siemens 2016 - 2026
* SPDX-License-Identifier: MIT
*/
import { Component, signal, viewChild } from '@angular/core';
import { ChangeDetectionStrategy, Component, signal, viewChild } from '@angular/core';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import { FormControl, ReactiveFormsModule } from '@angular/forms';

Expand All @@ -22,7 +22,8 @@ import { SiTimepickerComponent as TestComponent } from './index';
[showMeridian]="showMeridian()"
(inputCompleted)="onInputCompleted()"
/>
`
`,
changeDetection: ChangeDetectionStrategy.OnPush
})
class WrapperComponent {
readonly picker = viewChild.required<TestComponent>(TestComponent);
Expand Down
Loading