refactor(datepicker): explicitly define change detection strategy#2199
refactor(datepicker): explicitly define change detection strategy#2199spliffone wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several components within the datepicker module—specifically SiCalendarBodyComponent, SiInitialFocusComponent, SiDateRangeComponent, SiDatepickerComponent, and a test WrapperComponent—to utilize ChangeDetectionStrategy.OnPush for change detection. I have no feedback to provide as there are no review comments to evaluate.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
spike-rabbit
left a comment
spike-rabbit
left a comment
There was a problem hiding this comment.
please do not apply OnPush yet on public facing components. We should do this with v51 as the behavior may change for application if the only mutate single properties.
spliffone
force-pushed
the
refactor/datepicker-explicit-change-detection-strategy
branch
from
f6e7f02 to
b196e96
Compare
2 participants
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: