Skip to content

Fix the package.json reading so the list and terminal packages can be used again #3034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix the package.json reading so the list and terminal packages can be used again #3034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/list/lib/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { autoDetect, PortInfo } from '@serialport/bindings-cpp'
import { program, Option } from 'commander'
import { readFileSync } from 'node:fs'

const { version } = JSON.parse(readFileSync('../package.json', 'utf8'))
const { version } = JSON.parse(readFileSync(__dirname + '/../package.json', 'utf8'))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I humbly submit it might be better to use path.join(__dirname, '..', 'package.json');


const formatOption = new Option('-f, --format <type>', 'Format the output').choices(['text', 'json', 'jsonline', 'jsonl']).default('text')

Expand Down
2 changes: 1 addition & 1 deletion packages/terminal/lib/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { OutputTranslator } from './output-translator'
import { autoDetect, AutoDetectTypes } from '@serialport/bindings-cpp'
import { readFileSync } from 'node:fs'

const { version } = JSON.parse(readFileSync('../package.json', 'utf8'))
const { version } = JSON.parse(readFileSync(__dirname + '/../package.json', 'utf8'))
const binding = autoDetect()

const makeNumber = (input: string) => Number(input)
Expand Down