Fix the package.json reading so the list and terminal packages can be used again
#3034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh wait I did a duplicate Pull Request for the same problem... #3070 |
DarcInc
reviewed
Aug 26, 2025
| @@ -4,7 +4,7 @@ import { autoDetect, PortInfo } from '@serialport/bindings-cpp' | |||
| import { program, Option } from 'commander' | |||
| import { readFileSync } from 'node:fs' | |||
|
|
|||
| const { version } = JSON.parse(readFileSync('../package.json', 'utf8')) | |||
| const { version } = JSON.parse(readFileSync(__dirname + '/../package.json', 'utf8')) | |||
There was a problem hiding this comment.
I humbly submit it might be better to use path.join(__dirname, '..', 'package.json');
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2972.
This PR fixes the reading of the
package.jsonfor the@serialport/listand@serialport/terminalpackages.The issue was that is was attempting to read one level up from the current working directory, rather than from the location of the javascript file. This was causing it to not be able to find the file, or find the wrong file.
The fix is to use
__dirnameto get the full path to the javascript files location so we can construct a full path to thepackage.jsonfile to read it.