Skip to content

fix(data): skip members with zero identityCommitment #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(data): skip members with zero identityCommitment #1032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
984f60e
Update subgraph.test.ts
berZKerk Aug 14, 2025
8317b2d
Update subgraph.ts
berZKerk Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/data/src/subgraph.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ export default class SemaphoreSubgraph {
admin
${
members === true
? `members(orderBy: index) {
? `members(where: { identityCommitment_not: "0" }, orderBy: index) {
identityCommitment
}`
: ""
Expand Down Expand Up @@ -186,7 +186,7 @@ export default class SemaphoreSubgraph {
admin
${
members === true
? `members(orderBy: index) {
? `members(where: { identityCommitment_not: "0" }, orderBy: index) {
identityCommitment
}`
: ""
Expand Down
79 changes: 79 additions & 0 deletions packages/data/tests/subgraph.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,6 +342,50 @@ describe("SemaphoreSubgraph", () => {
]
})
})

it("Should exclude members with zero identityCommitment when getting group with members", async () => {
requestMocked.mockImplementationOnce(() =>
Promise.resolve({
groups: [
{
id: "1",
merkleTree: {
depth: 20,
size: 3,
root: "2"
},
admin: "0x7bcd6f009471e9974a77086a69289d16eadba286",
members: [
{
identityCommitment: "20"
},
{
identityCommitment: "17"
}
]
}
]
})
)

const expectedValue = await semaphore.getGroup("1", { members: true })

expect(expectedValue).toBeDefined()
expect(expectedValue.members).toBeDefined()
expect(Array.isArray(expectedValue.members)).toBeTruthy()
expect(expectedValue.members).toHaveLength(2)
expect(expectedValue.members).toContain("20")
expect(expectedValue.members).toContain("17")
expect(expectedValue.members).not.toContain("0")

// Verify that the GraphQL query includes the filter for non-zero identityCommitment
expect(requestMocked).toHaveBeenCalledWith(
expect.any(String),
expect.objectContaining({
data: expect.stringContaining('members(where: { identityCommitment_not: \\"0\\" }, orderBy: index)')
})
)
})
})

describe("# getGroupMembers", () => {
Expand Down Expand Up @@ -382,6 +426,41 @@ describe("SemaphoreSubgraph", () => {
const fun = () => semaphore.getGroupMembers(1 as any)
await expect(fun).rejects.toThrow("Parameter 'groupId' is not a string")
})

it("Should exclude members with zero identityCommitment (removed members)", async () => {
requestMocked.mockImplementationOnce(() =>
Promise.resolve({
groups: [
{
id: "1",
merkleTree: {
depth: 20,
size: 3,
root: "2"
},
admin: "0x7bcd6f009471e9974a77086a69289d16eadba286",
members: [
{
identityCommitment: "20"
},
{
identityCommitment: "17"
}
]
}
]
})
)

const expectedValue = await semaphore.getGroupMembers("1")

expect(expectedValue).toBeDefined()
expect(Array.isArray(expectedValue)).toBeTruthy()
expect(expectedValue).toHaveLength(2)
expect(expectedValue).toContain("20")
expect(expectedValue).toContain("17")
expect(expectedValue).not.toContain("0")
})
})

describe("# getGroupValidatedProofs", () => {
Expand Down