Skip to content

Conversation

berZKerk
Copy link

Description

Updated SemaphoreSubgraph queries to ignore members with identityCommitment equal to "0".
This prevents removed/invalid members from showing up in getGroup and getGroupMembers results.

Also added tests to make sure these members are filtered out and that the GraphQL query includes the proper where clause.

Related Issue(s)

Closes ##858

Other information

  • Two new test cases added for getGroup and getGroupMembers.
  • Verified the query filter is working as expected.

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run yarn format and yarn lint without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant