Skip to content

feat(serverless): make run image configurable in container deploy command #5229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
remyleone merged 3 commits into from
Dec 16, 2025
Merged

feat(serverless): make run image configurable in container deploy command #5229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59327c1
feat(serverless): make run image configurable
cyclimse Dec 15, 2025
45ad0b5
update docs and goldens
yfodil Dec 16, 2025
d12a02f
Merge branch 'master' into feat/serverless-deploy-make-runner-image-c…
yfodil Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cmd/scw/testdata/test-all-usage-container-deploy-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ USAGE:
ARGS:
[name] Name of the application (defaults to build-source's directory name)
[builder=paketobuildpacks/builder-jammy-base:latest] Builder image to use
[run-image=paketobuildpacks/run-jammy-base:latest] Run image to use
[dockerfile=Dockerfile] Path to the Dockerfile
[force-builder=false] Force the use of the builder image (even if a Dockerfile is present)
[build-source=.] Path to the build context
Expand Down
1 change: 1 addition & 0 deletions docs/commands/container.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,6 +361,7 @@ scw container deploy [arg=value ...]
|------|---|-------------|
| name | | Name of the application (defaults to build-source's directory name) |
| builder | Default: `paketobuildpacks/builder-jammy-base:latest` | Builder image to use |
| run-image | Default: `paketobuildpacks/run-jammy-base:latest` | Run image to use |
| dockerfile | Default: `Dockerfile` | Path to the Dockerfile |
| force-builder | Default: `false` | Force the use of the builder image (even if a Dockerfile is present) |
| build-source | Default: `.` | Path to the build context |
Expand Down
7 changes: 7 additions & 0 deletions internal/namespaces/container/v1beta1/custom_deploy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ type containerDeployRequest struct {
Name string

Builder string
RunImage string
Dockerfile string
ForceBuilder bool

Expand Down Expand Up @@ -67,6 +68,11 @@ func containerDeployCommand() *core.Command {
Short: "Builder image to use",
Default: core.DefaultValueSetter("paketobuildpacks/builder-jammy-base:latest"),
},
{
Name: "run-image",
Short: "Run image to use",
Default: core.DefaultValueSetter("paketobuildpacks/run-jammy-base:latest"),
},
{
Name: "dockerfile",
Short: "Path to the Dockerfile",
Expand Down Expand Up @@ -372,6 +378,7 @@ func DeployStepBuildpackBuildImage(
AppPath: data.Args.BuildSource,
Builder: data.Args.Builder,
Image: tag,
RunImage: data.Args.RunImage,
ClearCache: !data.Args.Cache,
TrustBuilder: func(string) bool { return true },
})
Expand Down
1,192 changes: 509 additions & 683 deletions ...amespaces/container/v1beta1/testdata/test-deploy-app-name-deduced-from-path.cassette.yaml
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions internal/namespaces/container/v1beta1/testdata/test-deploy-app-name-deduced-from-path.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
🎲🎲🎲 EXIT CODE: 0 🎲🎲🎲
🟩🟩🟩 STDOUT️ 🟩🟩🟩️
Your application is now available at https://appclitctnrdeployfpzayj9zdx-app-cli-t-ctnr-deploy-fp.functions.fnc.fr-par.scw.cloud
Your application is now available at https://appclitctnrdeployfpv7kvie1v-app-cli-t-ctnr-deploy-fp.functions.fnc.fr-par.scw.cloud

🟩🟩🟩 JSON STDOUT 🟩🟩🟩
"Your application is now available at https://appclitctnrdeployfpzayj9zdx-app-cli-t-ctnr-deploy-fp.functions.fnc.fr-par.scw.cloud\n"
"Your application is now available at https://appclitctnrdeployfpv7kvie1v-app-cli-t-ctnr-deploy-fp.functions.fnc.fr-par.scw.cloud\n"
1,136 changes: 417 additions & 719 deletions internal/namespaces/container/v1beta1/testdata/test-deploy-build-args.cassette.yaml
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions internal/namespaces/container/v1beta1/testdata/test-deploy-build-args.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
🎲🎲🎲 EXIT CODE: 0 🎲🎲🎲
🟩🟩🟩 STDOUT️ 🟩🟩🟩️
Your application is now available at https://clitctnrdeploybanaloas4l-cli-t-ctnr-deploy-ba.functions.fnc.fr-par.scw.cloud
Your application is now available at https://clitctnrdeploybao7dknudy-cli-t-ctnr-deploy-ba.functions.fnc.fr-par.scw.cloud

🟩🟩🟩 JSON STDOUT 🟩🟩🟩
"Your application is now available at https://clitctnrdeploybanaloas4l-cli-t-ctnr-deploy-ba.functions.fnc.fr-par.scw.cloud\n"
"Your application is now available at https://clitctnrdeploybao7dknudy-cli-t-ctnr-deploy-ba.functions.fnc.fr-par.scw.cloud\n"
13,202 changes: 2,469 additions & 10,733 deletions internal/namespaces/container/v1beta1/testdata/test-deploy-buildpack.cassette.yaml
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions internal/namespaces/container/v1beta1/testdata/test-deploy-buildpack.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
🎲🎲🎲 EXIT CODE: 0 🎲🎲🎲
🟩🟩🟩 STDOUT️ 🟩🟩🟩️
Your application is now available at https://clitctnrdeploybp5rwcoxvx-cli-t-ctnr-deploy-bp.functions.fnc.fr-par.scw.cloud
Your application is now available at https://clitctnrdeploybpzlimduyi-cli-t-ctnr-deploy-bp.functions.fnc.fr-par.scw.cloud

🟩🟩🟩 JSON STDOUT 🟩🟩🟩
"Your application is now available at https://clitctnrdeploybp5rwcoxvx-cli-t-ctnr-deploy-bp.functions.fnc.fr-par.scw.cloud\n"
"Your application is now available at https://clitctnrdeploybpzlimduyi-cli-t-ctnr-deploy-bp.functions.fnc.fr-par.scw.cloud\n"
1,470 changes: 653 additions & 817 deletions internal/namespaces/container/v1beta1/testdata/test-deploy-simple.cassette.yaml
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions internal/namespaces/container/v1beta1/testdata/test-deploy-simple.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
🎲🎲🎲 EXIT CODE: 0 🎲🎲🎲
🟩🟩🟩 STDOUT️ 🟩🟩🟩️
Your application is now available at https://clitctnrdeploysy040pszu-cli-t-ctnr-deploy-s.functions.fnc.fr-par.scw.cloud
Your application is now available at https://clitctnrdeploysnwevqmkl-cli-t-ctnr-deploy-s.functions.fnc.fr-par.scw.cloud

🟩🟩🟩 JSON STDOUT 🟩🟩🟩
"Your application is now available at https://clitctnrdeploysy040pszu-cli-t-ctnr-deploy-s.functions.fnc.fr-par.scw.cloud\n"
"Your application is now available at https://clitctnrdeploysnwevqmkl-cli-t-ctnr-deploy-s.functions.fnc.fr-par.scw.cloud\n"
Loading
Loading