Skip to content

Conversation

@cyclimse
Copy link
Contributor

@cyclimse cyclimse commented Dec 15, 2025

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Hello there!

I often use scw container deploy, but it's a bit annoying to not be able to override the packer run-image when needing specific tools installed in the container (stuff to debug network issues, for instance). Ideally, one could overwrite the run-image to inject their own. Currently we rely on the builder's default.

Release note for CHANGELOG:

Add `run-image=` argument to `scw container deploy` command to be able to override the final Serverless container environment

@cyclimse cyclimse changed the title feat(serverless): make run image configurable feat(serverless): make run image configurable in container deploy command Dec 15, 2025
@cyclimse cyclimse marked this pull request as ready for review December 15, 2025 14:00
@cyclimse cyclimse requested a review from a team as a code owner December 15, 2025 14:00
remyleone
remyleone previously approved these changes Dec 15, 2025
@remyleone remyleone enabled auto-merge December 15, 2025 14:06
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.13%. Comparing base (d4fb5bf) to head (d12a02f).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5229   +/-   ##
=======================================
  Coverage   57.13%   57.13%           
=======================================
  Files         313      313           
  Lines       69977    69982    +5     
=======================================
+ Hits        39982    39987    +5     
  Misses      28500    28500           
  Partials     1495     1495           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added container Container issues, bugs and feature requests function Serverless function issues, bugs and feature requests labels Dec 15, 2025
@remyleone remyleone added this pull request to the merge queue Dec 16, 2025
Merged via the queue into master with commit a36b432 Dec 16, 2025
124 checks passed
@remyleone remyleone deleted the feat/serverless-deploy-make-runner-image-configurable branch December 16, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

container Container issues, bugs and feature requests function Serverless function issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants