-
-
Notifications
You must be signed in to change notification settings - Fork 2
[Snyk] Fix for 4 vulnerabilities #584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -94,7 +94,7 @@ | |||||
| "@bull-board/express": "^4.3.1", | ||||||
| "@bull-board/ui": "^4.12.2", | ||||||
| "@elastic/elasticsearch": "^7.17.0", | ||||||
| "@parse/node-apn": "^5.1.3", | ||||||
| "@parse/node-apn": "^7.0.0", | ||||||
| "@saurabharch/json-rules-engine": "^6.1.2", | ||||||
| "@saurabharch/rollout-chatbot-util": "^0.8.37", | ||||||
| "@saurabharch/rollout-node-sdk": "^0.0.6", | ||||||
|
|
@@ -200,7 +200,7 @@ | |||||
| "node-rsa": "^1.1.1", | ||||||
| "node-schedule": "^2.1.0", | ||||||
| "node-uuid": "^1.4.8", | ||||||
| "nodemailer": "^6.7.8", | ||||||
| "nodemailer": "^7.0.11", | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The
Suggested change
|
||||||
| "numeral": "^2.0.6", | ||||||
| "oauth2orize": "^1.11.1", | ||||||
| "oauthorize": "^0.1.0", | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a major version upgrade from v5 to v7 for
@parse/node-apn. Version 6 of this library introduced a significant breaking change by removing support for callbacks and moving to aPromise-based API. Your code insrc/jobs/PushNotification.jsappears to use a callback-style API via therollout-pushnotificationwrapper. This update is very likely to break Apple Push Notifications. Please verify compatibility and update your code to use Promises if necessary before merging this change. Given the risk, you might want to find the minimum version that fixes the vulnerability without introducing breaking changes.