-
-
Notifications
You must be signed in to change notification settings - Fork 2
[Snyk] Fix for 4 vulnerabilities #584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-NODEMAILER-14157156 - https://snyk.io/vuln/SNYK-JS-NODEFORGE-14114940 - https://snyk.io/vuln/SNYK-JS-NODEFORGE-14125745 - https://snyk.io/vuln/SNYK-JS-NODEFORGE-14125097
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello @saurabharch, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to bolster the project's security by resolving four identified vulnerabilities within its npm dependencies. It achieves this by upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request from Snyk aims to fix security vulnerabilities by upgrading @parse/node-apn and nodemailer. However, the proposed changes have critical flaws. The target version for nodemailer (7.0.11) does not exist, which will break the build. The upgrade for @parse/node-apn is a major version jump (v5 to v7) that includes breaking changes, specifically the removal of callback support, which your project seems to rely on. This will likely break push notifications. I recommend manually updating these dependencies to versions that fix the vulnerabilities without introducing these issues. Also, remember to regenerate and commit package-lock.json after making the changes.
| "node-schedule": "^2.1.0", | ||
| "node-uuid": "^1.4.8", | ||
| "nodemailer": "^6.7.8", | ||
| "nodemailer": "^7.0.11", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The nodemailer package is being updated to version 7.0.11, which does not exist in the npm registry. This will cause npm install to fail. To fix the Snyk vulnerability SNYK-JS-NODEMAILER-14157156, you should update to a version like 6.9.8 or higher within the 6.x series. The latest version is 6.9.13.
| "nodemailer": "^7.0.11", | |
| "nodemailer": "^6.9.13", |
| "@bull-board/ui": "^4.12.2", | ||
| "@elastic/elasticsearch": "^7.17.0", | ||
| "@parse/node-apn": "^5.1.3", | ||
| "@parse/node-apn": "^7.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a major version upgrade from v5 to v7 for @parse/node-apn. Version 6 of this library introduced a significant breaking change by removing support for callbacks and moving to a Promise-based API. Your code in src/jobs/PushNotification.js appears to use a callback-style API via the rollout-pushnotification wrapper. This update is very likely to break Apple Push Notifications. Please verify compatibility and update your code to use Promises if necessary before merging this change. Given the risk, you might want to find the minimum version that fixes the vulnerability without introducing breaking changes.
Snyk has created this PR to fix 4 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):
package.jsonVulnerabilities that will be fixed with an upgrade:
SNYK-JS-NODEMAILER-14157156
SNYK-JS-NODEFORGE-14114940
SNYK-JS-NODEFORGE-14125745
SNYK-JS-NODEFORGE-14125097
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.