Fix size deprecation warnings in ImageDimPlot and ImageFeaturePlot #10210
+4
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when using ImageDimPlot or ImageFeaturePlot in Seurat with ggplot2 v4.0.0+, users encounter the following warnings:
Warnings
1: The size argument of element_rect() is deprecated as of ggplot2 3.4.0.
i Please use the linewidth argument instead.
i The deprecated feature was likely used in the Seurat package.
This warning is displayed once every 8 hours.
Call lifecycle::last_lifecycle_warnings() to see where this warning was generated.
2: The size argument of element_line() is deprecated as of ggplot2 3.4.0.
i Please use the linewidth argument instead.
i The deprecated feature was likely used in the Seurat package.
This warning is displayed once every 8 hours.
Call lifecycle::last_lifecycle_warnings() to see where this warning was generated.
This quick fix addresses these warnings by replacing the "size" parameters in element_rect, element_line, and geom_polygon as used in visualization.R with "linewidth", which ggplot2 has mentioned to supersede the size variable: https://ggplot2.tidyverse.org/news/index.html
With these changes, the following commands should have the same behaviour and not cause warnings when running either ggplot2 <4.0.0 or 4.0.0+: