Fix Bug in IntegrateEmbeddings when Ref is specified #10172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eference is specified
anashen
force-pushed
the
IntegrateEmbeddingsWithRefFixDims
branch
from
745b1cb to
577c139
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear developpers,
I noticed that if I want to use IntegrateEmbeddings but I specify
dims.to.integrateandreferenceI get an error:I could find the origin of the problem. I also so that there was a similar commit: c9f8b5e but unfortunately only the case where reference was not specified was fixed.
You find here the fix for the case where
referenceis specified.