Fix do.call slowdown by amending Parenting #10161
Open
+15
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a performance regression in the Parenting function that causes severe slowdowns (from 61 seconds to 25 minutes) when large objects are passed through do.call(). The fix replaces the original string-based call serialization approach with a more efficient extraction of function names from the call stack.
- Replaces
as.character(sys.calls())with direct call parsing to avoid serializing large objects - Uses
vapplyfor type-safe iteration over call stack entries - Handles both simple function names and qualified names (e.g.,
pkg::function)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Addresses PR comment feedback about incorrect handling of package-qualified function names like pkg::func. Using paste(collapse='') would produce '::pkgfunc' instead of the correct 'pkg::func'. The deparse1() function properly reconstructs the syntax for all cases: - Simple names: 'func' - Qualified names: 'pkg::func' - Operators: '[[' Verified: - All existing tests pass - Performance remains excellent (do.call 0.16x of direct call) - Results are identical
Verified that direct call and do.call produce identical results: - All data layers match byte-for-byte - Variable features identical - All tests pass Explained apparent speed difference: - First call pays ~7s warmup cost (code loading, compilation) - Subsequent calls take ~0.78s for both methods - Performance is truly identical after warmup Results: - Before fix: do.call took 1800+ seconds - After fix: do.call takes 0.78 seconds (same as direct) - Improvement: ~2300x faster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10153.
On main, this takes 25 minutes. On this branch, it takes 61 seconds.
In the interest of transparency this was generated by GitHub's Copilot w/ claude-sonnet-4.5.