Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Dec 9, 2025


This is an automatic backport of pull request #2879 done by [Mergify](https://mergify.com).

(cherry picked from commit 67f836d)

# Conflicts:
#	hardware_interface/include/hardware_interface/handle.hpp
#	hardware_interface/test/test_handle.cpp
@mergify mergify bot added the conflicts label Dec 9, 2025
@mergify
Copy link
Contributor Author

mergify bot commented Dec 9, 2025

Cherry-pick of 67f836d has failed:

On branch mergify/bp/jazzy/pr-2879
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit 67f836d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   doc/release_notes.rst
	modified:   hardware_interface/doc/hardware_interface_types_userdoc.rst
	modified:   hardware_interface/include/hardware_interface/hardware_info.hpp
	modified:   hardware_interface/include/hardware_interface/lexical_casts.hpp
	modified:   hardware_interface/src/lexical_casts.cpp
	modified:   hardware_interface/test/test_lexical_casts.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   hardware_interface/include/hardware_interface/handle.hpp
	both modified:   hardware_interface/test/test_handle.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@christophfroehlich
Copy link
Member

@saikishor did this go in intentionally?

value = static_cast<double>(std::get<bool>(value_));

I removed it again here (we have released it already)

@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 92.64706% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.36%. Comparing base (ab304b5) to head (d6c322c).
⚠️ Report is 3 commits behind head on jazzy.

Files with missing lines Patch % Lines
...re_interface/include/hardware_interface/handle.hpp 80.23% 17 Missing ⚠️
...rface/include/hardware_interface/lexical_casts.hpp 80.00% 0 Missing and 4 partials ⚠️
hardware_interface/src/lexical_casts.cpp 75.00% 0 Missing and 3 partials ⚠️
hardware_interface/test/test_handle.cpp 99.41% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy    #2896      +/-   ##
==========================================
+ Coverage   89.30%   89.36%   +0.06%     
==========================================
  Files         155      155              
  Lines       18137    18465     +328     
  Branches     1474     1480       +6     
==========================================
+ Hits        16197    16502     +305     
- Misses       1359     1375      +16     
- Partials      581      588       +7     
Flag Coverage Δ
unittests 89.36% <92.64%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rface/include/hardware_interface/hardware_info.hpp 98.78% <100.00%> (+5.92%) ⬆️
hardware_interface/test/test_lexical_casts.cpp 100.00% <100.00%> (ø)
hardware_interface/test/test_handle.cpp 99.06% <99.41%> (+0.40%) ⬆️
hardware_interface/src/lexical_casts.cpp 83.78% <75.00%> (-0.84%) ⬇️
...rface/include/hardware_interface/lexical_casts.hpp 73.33% <80.00%> (+5.33%) ⬆️
...re_interface/include/hardware_interface/handle.hpp 81.62% <80.23%> (+2.64%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@saikishor
Copy link
Member

I removed it again here (we have released it already)

I'm fine to remove it, but I guess @destogl is using it

@christophfroehlich christophfroehlich merged commit 2793795 into jazzy Dec 10, 2025
14 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/jazzy/pr-2879 branch December 10, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants