-
Notifications
You must be signed in to change notification settings - Fork 388
Fix the CM statistics async publish placement #2865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the CM statistics async publish placement #2865
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2865 +/- ##
==========================================
+ Coverage 89.56% 89.57% +0.01%
==========================================
Files 155 155
Lines 18105 18104 -1
Branches 1474 1474
==========================================
+ Hits 16215 16217 +2
+ Misses 1302 1300 -2
+ Partials 588 587 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christophfroehlich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To understand that: We want to publish the data once per cm cycle, which is read-update-write-wait. And earlier this was updated in the update method, which means the data of the write were one cycle old?
My interpretation is that we want to publish the data( |
Juliaj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Yes, it was one cycle old, and that's why the visualization didn't add up |
(cherry picked from commit f0f003f)
(cherry picked from commit f0f003f)
(cherry picked from commit f0f003f) Co-authored-by: Sai Kishor Kothakota <[email protected]>
(cherry picked from commit f0f003f) Co-authored-by: Sai Kishor Kothakota <[email protected]>
Right now, the image looks like below instead of the expected_total_time. inorder to fix it, we need to move the statistics publishing to the write callback part, and the other one is good at its place
