-
Notifications
You must be signed in to change notification settings - Fork 388
Don't update state interfaces if command interfaces are not finite #2786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2786 +/- ##
==========================================
- Coverage 89.60% 89.57% -0.03%
==========================================
Files 152 152
Lines 17719 17720 +1
Branches 1456 1457 +1
==========================================
- Hits 15877 15873 -4
- Misses 1254 1258 +4
- Partials 588 589 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
saikishor
approved these changes
Nov 9, 2025
MarqRazz
approved these changes
Nov 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-jazzy
Triggers PR backport to ROS 2 jazzy.
backport-kilted
Triggers PR backport to ROS 2 kilted.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @MarqRazz: In setups with
calculate_dynamics=falseand where the command_interfaces don't have initial values, the state interfaces were overwritten with NaNs.