chore: disable OTEL by default in guard service - #2522
Closed
NathanFlurry wants to merge 1 commit into
Closed
Conversation
This was referenced Jun 2, 2025
This was referenced Jun 2, 2025
Closed
This was referenced Jun 2, 2025
Member
Author
MasterPtato
force-pushed
the
chore_increase_file_watch_limit_for_rivet_guard
branch
from
June 3, 2025 01:54
5d166fe to
c6bfdf2
Compare
MasterPtato
force-pushed
the
chore_disable_OTEL_by_default_in_guard_service
branch
from
June 3, 2025 01:54
01599e8 to
137d99c
Compare
MasterPtato
marked this pull request as ready for review
June 3, 2025 01:55
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Disables OpenTelemetry (OTEL) by default in the Rivet Guard service to reduce memory consumption by removing the RIVET_OTEL_ENABLED environment variable.
- Removed
RIVET_OTEL_ENABLEDfrom/packages/core/services/cluster/src/workflows/server/install/install_scripts/files/rivet_guard_configure.sh - Consider removing
RIVET_OTEL_SAMPLER_RATIO=1since it has no effect when OTEL is disabled - Added clarifying comment about OTEL's memory consumption in systemd service configuration
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+18
to
19
| # OTEL is not enabled by default since it eats memory very quickly | ||
| Environment="RIVET_OTEL_SAMPLER_RATIO=1" |
There was a problem hiding this comment.
logic: RIVET_OTEL_SAMPLER_RATIO=1 has no effect if OTEL is disabled. Consider removing this line entirely to avoid confusion.
Deploying rivet-hub with
|
| Latest commit: |
137d99c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1b40cd9e.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://chore-disable-otel-by-defaul.rivet-hub-7jb.pages.dev |
Deploying rivet with
|
| Latest commit: |
137d99c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1ae48c63.rivet.pages.dev |
| Branch Preview URL: | https://chore-disable-otel-by-defaul.rivet.pages.dev |
Deploying rivet-studio with
|
| Latest commit: |
137d99c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1814f08f.rivet-studio.pages.dev |
| Branch Preview URL: | https://chore-disable-otel-by-defaul.rivet-studio.pages.dev |
Contributor
Merge activity
|
graphite-app Bot
pushed a commit
that referenced
this pull request
Jun 3, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
Bot
deleted the
chore_disable_OTEL_by_default_in_guard_service
branch
June 3, 2025 07:03
This was referenced Jun 3, 2025
This was referenced Jun 4, 2025
Closed
This was referenced Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes