chore: fix guard metrics - #2504
Closed
MasterPtato wants to merge 1 commit into
Closed
Conversation
This was referenced May 31, 2025
Contributor
Author
This was referenced May 31, 2025
Closed
There was a problem hiding this comment.
PR Summary
Optimizes error handling and metrics recording in the Guard proxy service to prevent race conditions and ensure logical ordering of metric collection.
- Restructured metrics recording in
packages/edge/infra/guard/core/src/proxy_service.rsto capture status codes within successful request handling block - Separated error metric recording into dedicated error handling block for better isolation
- Improved request lifecycle tracking by ensuring metrics are recorded in sequential order
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
NathanFlurry
force-pushed
the
05-31-chore_fix_guard_metrics
branch
from
May 31, 2025 01:01
33cc1e7 to
b867000
Compare
NathanFlurry
force-pushed
the
05-30-feat_add_pb_usage_metrics_server_state
branch
from
May 31, 2025 01:01
2f17dc8 to
1eac431
Compare
MasterPtato
force-pushed
the
05-30-feat_add_pb_usage_metrics_server_state
branch
from
May 31, 2025 01:04
1eac431 to
2f17dc8
Compare
MasterPtato
force-pushed
the
05-31-chore_fix_guard_metrics
branch
from
May 31, 2025 01:04
b867000 to
ec91701
Compare
Deploying rivet with
|
| Latest commit: |
3e7664e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8e4f31d8.rivet.pages.dev |
| Branch Preview URL: | https://05-31-chore-fix-guard-metric.rivet.pages.dev |
Deploying rivet-hub with
|
| Latest commit: |
3e7664e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://deb48fe8.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://05-31-chore-fix-guard-metric.rivet-hub-7jb.pages.dev |
Deploying rivet-studio with
|
| Latest commit: |
3e7664e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://160e77ee.rivet-studio.pages.dev |
| Branch Preview URL: | https://05-31-chore-fix-guard-metric.rivet-studio.pages.dev |
NathanFlurry
force-pushed
the
05-31-chore_fix_guard_metrics
branch
from
May 31, 2025 01:52
ec91701 to
edec6dc
Compare
NathanFlurry
force-pushed
the
05-30-feat_add_pb_usage_metrics_server_state
branch
from
May 31, 2025 01:52
2f17dc8 to
1eac431
Compare
MasterPtato
force-pushed
the
05-31-chore_fix_guard_metrics
branch
from
May 31, 2025 02:05
edec6dc to
be42f65
Compare
MasterPtato
force-pushed
the
05-31-chore_fix_guard_metrics
branch
from
June 2, 2025 18:13
be42f65 to
3e7664e
Compare
MasterPtato
force-pushed
the
05-30-feat_add_pb_usage_metrics_server_state
branch
from
June 2, 2025 18:13
2f17dc8 to
39fc637
Compare
NathanFlurry
force-pushed
the
05-31-chore_fix_guard_metrics
branch
from
June 2, 2025 20:12
3e7664e to
6d6cc7e
Compare
NathanFlurry
force-pushed
the
05-30-feat_add_pb_usage_metrics_server_state
branch
from
June 2, 2025 20:12
39fc637 to
a7ff390
Compare
This was referenced Jun 2, 2025
This was referenced Jun 3, 2025
Closed
This was referenced Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Changes