Skip to content

Event tampering vulnerability #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nogringo wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Event tampering vulnerability #346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb46856
feat: add test
nogringo Dec 22, 2025
ac2fa10
fix: bip340 event verifier
nogringo Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/ndk/lib/data_layer/repositories/verifiers/bip340_event_verifier.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import '../../../domain_layer/repositories/event_verifier.dart';
class Bip340EventVerifier implements EventVerifier {
@override
Future<bool> verify(Nip01Event event) async {
if (!event.isIdValid) return false;
Copy link
Collaborator

@frnandu frnandu Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will need to change to
Nip01Utils.isIdValid(event)
after #332 is merged...

return bip340.verify(event.pubKey, event.id, event.sig);
}
}
52 changes: 52 additions & 0 deletions packages/ndk/test/verifiers/event_id_verification_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
import 'package:ndk/ndk.dart';
import 'package:test/test.dart';

void main() {
test('verify real event', () async {
final event = Nip01Event.fromJson({
"id": "3c65c446bd71fa90e5c4177abf8526868dbc4b230b15ea8df3fa7ee33145993b",
"pubkey":
"52d4650e933525817021571f2e82859da3b5ad44e74ef6498a8af5ff8d7dcc83",
"created_at": 1766398063,
"kind": 1,
"tags": [],
"content": "content",
"sig":
"eff0ae7d37d9739baa920fee76792974bfc0b27219a20c728dd143d8188395abb35ff6b09acbf0049a60f5c73b0a2a154f014bc02e08902c78f07f5c422ae607"
});

expect(await Bip340EventVerifier().verify(event), isTrue);
});

test('verify event with tampered id', () async {
final event = Nip01Event.fromJson({
"id": "3c65c446bd71fa90e5c4177abf8526868dbc4b230b15ea8df3fa7ee33145aaaa",
"pubkey":
"52d4650e933525817021571f2e82859da3b5ad44e74ef6498a8af5ff8d7dcc83",
"created_at": 1766398063,
"kind": 1,
"tags": [],
"content": "content",
"sig":
"eff0ae7d37d9739baa920fee76792974bfc0b27219a20c728dd143d8188395abb35ff6b09acbf0049a60f5c73b0a2a154f014bc02e08902c78f07f5c422ae607"
});

expect(await Bip340EventVerifier().verify(event), isFalse);
});

test('verify event with tampered created at', () async {
final event = Nip01Event.fromJson({
"id": "3c65c446bd71fa90e5c4177abf8526868dbc4b230b15ea8df3fa7ee33145993b",
"pubkey":
"52d4650e933525817021571f2e82859da3b5ad44e74ef6498a8af5ff8d7dcc83",
"created_at": 1766394444,
"kind": 1,
"tags": [],
"content": "content",
"sig":
"eff0ae7d37d9739baa920fee76792974bfc0b27219a20c728dd143d8188395abb35ff6b09acbf0049a60f5c73b0a2a154f014bc02e08902c78f07f5c422ae607"
});

expect(await Bip340EventVerifier().verify(event), isFalse);
});
}