Event tampering vulnerability #346
Open
+53
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #346 +/- ##
=======================================
Coverage 70.72% 70.72%
=======================================
Files 136 136
Lines 5069 5070 +1
=======================================
+ Hits 3585 3586 +1
Misses 1484 1484 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
frnandu
approved these changes
Dec 23, 2025
| class Bip340EventVerifier implements EventVerifier { | ||
| @override | ||
| Future<bool> verify(Nip01Event event) async { | ||
| if (!event.isIdValid) return false; |
Collaborator
There was a problem hiding this comment.
this will need to change to
Nip01Utils.isIdValid(event)
after #332 is merged...
1-leo
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bad relay can serve bad events and NDK will never notice. Bad events can be an event with the content updated by the relay operator.