Skip to content

RDKEAPPRT 751 -Enhance Authentication Feedback UI for App Catalogue (Success & Failure States) #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
suryag23 wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

RDKEAPPRT 751 -Enhance Authentication Feedback UI for App Catalogue (Success & Failure States) #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f6427ad
RDKEAPPRT-751: Add catalog URL display and improve app catalog login …
vaisakh806 May 6, 2026
aaab14b
Rebased the 751 changes
suryag23 May 25, 2026
ead561f
RDKEAPPRT-751: Include local changes for app catalog login and transl…
suryag23 May 25, 2026
69f5c6b
addressed the review comments
suryag23 May 25, 2026
a5eb6a5
addressed the review comments
suryag23 May 26, 2026
1ef94a0
Addressed the review comments
suryag23 May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion accelerator-home-ui/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@
"log": true,
"enableAppSuspended": true,
"showVersion": false,
"version": "6.0.12"
"version": "6.0.13"
}
}
8 changes: 8 additions & 0 deletions accelerator-home-ui/src/api/AppCatalog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,10 @@ export async function login(user, pass) {

try {
const loginResponse = await handler.login(user, pass);
if (!loginResponse || typeof loginResponse.expiresIn !== 'number') {
console.warn('Login failed: invalid response from server', loginResponse);
return false;
}
Comment on lines +423 to +426
Copy link
Copy Markdown
Contributor

@astolcenburg astolcenburg May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not needed, the wrong behavior we observe is caused by the server side.

appCatalogHandler = handler;
handler.scheduleRefresh(loginResponse, () => handleAuthExpired(handler));
Comment thread
suryag23 marked this conversation as resolved.
eventTarget.dispatchEvent(new RefreshNeeded());
Expand Down Expand Up @@ -447,3 +451,7 @@ export async function makeDownloadURL(url) {
const handler = appCatalogHandler;
return callAndHandleAuthExpired(handler, () => handler.makeDownloadURL(url));
}

export async function getCatalogServerURL() {
return getServerURL();
}
Loading
Loading