RDKEAPPRT 751 -Enhance Authentication Feedback UI for App Catalogue (Success & Failure States)#198
Open
suryag23 wants to merge 6 commits into
Open
RDKEAPPRT 751 -Enhance Authentication Feedback UI for App Catalogue (Success & Failure States)#198suryag23 wants to merge 6 commits into
suryag23 wants to merge 6 commits into
Conversation
…experience - Validate login responses and add server URL export - Display catalog URL in login component UI - Add Connect button with dynamic color validation - Implement loading spinner during authentication - Add error handling popups for authentication failures Please refer ticket for more detials
There was a problem hiding this comment.
Pull request overview
Enhances the App Catalog login experience by adding clearer authentication feedback UI (success/failure/loading states) and exposing the resolved App Catalog server URL to the login screen, alongside bumping the Ref UI version.
Changes:
- Add Connect button flow with loading overlay and error popups in the App Catalog login screen, plus display of the resolved catalog server URL.
- Tighten App Catalog
login()handling and export a helper to retrieve the catalog server URL. - Update Spanish translations and bump application version to
6.0.13.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| bolt/package-configs/com.rdkcentral.refui.json | Bumps Ref UI package version to 6.0.13. |
| accelerator-home-ui/static/language/translations/es.json | Adds new Spanish strings for auth/login failures and App Catalog URL label. |
| accelerator-home-ui/src/screens/AppCatalogLoginComponent.js | Adds URL display, Connect button, loading overlay, and failure popups for App Catalog authentication. |
| accelerator-home-ui/src/api/AppCatalog.js | Adds stricter login response validation and exports a server-URL accessor. |
| accelerator-home-ui/settings.json | Bumps UI settings version to 6.0.13. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Comments suppressed due to low confidence (1)
accelerator-home-ui/static/language/translations/en.json:140
- This file now contains duplicate JSON keys (e.g.
"Press OK to enter Password","Show Password","Connect") that already exist earlier in the same file. Duplicate keys can be rejected by some JSON tooling and are ambiguous (later entries override earlier ones). Please remove the duplicates and keep a single entry per key.
"Connect to the Application Catalog":"Connect to the Application Catalog",
"App Catalog URL":"App Catalog URL",
"Press OK to enter Username":"Press OK to enter Username",
"Press OK to enter Password":"Press OK to enter Password",
"Show Password":"Show Password",
"Connect":"Connect",
Comment on lines
+423
to
+426
| if (!loginResponse || typeof loginResponse.expiresIn !== 'number') { | ||
| console.warn('Login failed: invalid response from server', loginResponse); | ||
| return false; | ||
| } |
Contributor
There was a problem hiding this comment.
This change is not needed, the wrong behavior we observe is caused by the server side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.