Skip to content

Selenium: Verify consumer state when using SAC (backport #13950) #13968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 28, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented May 28, 2025

Proposed Changes

Address issue #13045
The selenium test added on this PR could reproduce the issue #13045. This PR adds a patch (provided by @ansd ) that addresses.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

This is an automatic backport of pull request #13950 done by [Mergify](https://mergify.com).

(cherry picked from commit 70ec8df)

# Conflicts:
#	deps/rabbitmq_management/priv/www/js/tmpl/quorum-queue-stats.ejs
(cherry picked from commit 586a946)
Required to subscribe with a priority in the arguments
which is only possible in AMQP 0.9.1

(cherry picked from commit 4fdbcb3)
(cherry picked from commit d276798)
And improve how to parse a html table to
extract its rows

(cherry picked from commit 8960d19)
(cherry picked from commit 98061c8)
To prevent state element exception

(cherry picked from commit a922429)
@mergify mergify bot added the conflicts label May 28, 2025
Copy link
Author

mergify bot commented May 28, 2025

Cherry-pick of 70ec8df has failed:

On branch mergify/bp/v4.1.x/pr-13950
Your branch is up to date with 'origin/v4.1.x'.

You are currently cherry-picking commit 70ec8dffd.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   deps/rabbitmq_management/priv/www/js/tmpl/consumers.ejs
	modified:   deps/rabbitmq_management/priv/www/js/tmpl/queue.ejs
	modified:   selenium/Dockerfile
	modified:   selenium/test/amqp.js
	modified:   selenium/test/mgt-api.js
	modified:   selenium/test/pageobjects/BasePage.js
	modified:   selenium/test/pageobjects/QueuePage.js
	new file:   selenium/test/queuesAndStreams/view-qq-consumers.js
	modified:   selenium/test/utils.js
	modified:   selenium/test/vhosts/admin-vhosts.js

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   deps/rabbitmq_management/priv/www/js/tmpl/quorum-queue-stats.ejs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@michaelklishin michaelklishin added this to the 4.1.1 milestone May 28, 2025
@michaelklishin michaelklishin merged commit 938a2f5 into v4.1.x May 28, 2025
539 of 540 checks passed
@michaelklishin michaelklishin deleted the mergify/bp/v4.1.x/pr-13950 branch May 28, 2025 11:01
@michaelklishin michaelklishin removed this from the 4.1.1 milestone May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants