Test SAC with priority consumers #14000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansd
requested changes
Jun 2, 2025
Comment on lines
1753
to
1757
| {#rabbit_fifo{ cfg = #cfg{resource = Resource}}, ModCalls} = run_log(Config, S0, Entries, fun single_active_invariant/1), | ||
| {mod_call,rabbit_quorum_queue,update_consumer_handler, | ||
| [Resource, | ||
| _, | ||
| false,undefined,undefined,false,waiting,[]]} = lists:nth(3, ModCalls), |
There was a problem hiding this comment.
You added an assertion for only the 3rd effect.
Can we add an assertion that checks for all expected mod_call effects updating the consumers' activity statuses? Even the order of the returned effects can be asserted.
This way, test coverage for updating the consumer activity status will be complete and the test will be easier to understand.
There was a problem hiding this comment.
Absolutely ! thanks for reviewing it
MarcialRosales
force-pushed
the
test-sac-with-priorities
branch
2 times, most recently
from
f2e34f6 to
dc4c578
Compare
ansd
approved these changes
Jun 2, 2025
MarcialRosales
force-pushed
the
test-sac-with-priorities
branch
from
dc4c578 to
bd037a1
Compare
MarcialRosales
changed the title
6 tasks
michaelklishin
added a commit
that referenced
this pull request
Jun 2, 2025
Test SAC with priority consumers (cherry picked from commit 2b2e4d4)
|
Backported manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a unit test for a patch done on a separate PR #13968
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply