Skip to content

Selenium: Verify consumer state when using SAC #13950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 28, 2025
Merged

Selenium: Verify consumer state when using SAC #13950

merged 10 commits into from
May 28, 2025

Conversation

MarcialRosales
Copy link
Contributor

@MarcialRosales MarcialRosales commented May 26, 2025 •
edited
Loading

Proposed Changes

Address issue #13045
The selenium test added on this PR could reproduce the issue #13045. This PR adds a patch (provided by @ansd ) that addresses.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

@MarcialRosales MarcialRosales self-assigned this May 26, 2025
@MarcialRosales MarcialRosales marked this pull request as ready for review May 26, 2025 15:16
@MarcialRosales MarcialRosales marked this pull request as draft May 26, 2025 15:20
@MarcialRosales MarcialRosales marked this pull request as ready for review May 27, 2025 15:16
@michaelklishin michaelklishin added this to the 4.2.0 milestone May 28, 2025
@michaelklishin michaelklishin merged commit 49341b7 into main May 28, 2025
559 of 560 checks passed
@michaelklishin michaelklishin deleted the fix-13045 branch May 28, 2025 07:52
@mergify mergify bot mentioned this pull request May 28, 2025
Merged
6 tasks
michaelklishin added a commit that referenced this pull request May 28, 2025
@michaelklishin
Merge pull request #13968 from rabbitmq/mergify/bp/v4.1.x/pr-13950
938a2f5 
Selenium: Verify consumer state when using SAC (backport #13950)
mkuratczyk added a commit that referenced this pull request May 30, 2025
@mkuratczyk
Revert #13950
d7ed2e1 
Revert the rabbit_fifo.erl change from #13950

We noticed a strange test flake(?) and it seems like it first happened
after that PR.
@mkuratczyk mkuratczyk mentioned this pull request May 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelklishin michaelklishin michaelklishin approved these changes

Assignees

@MarcialRosales MarcialRosales

Labels
backport-v4.1.x
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcialRosales @michaelklishin