Skip to content

Fix for Integration Tests with test profiles: dev services config overrides #48627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ozangunalp
Copy link
Contributor

@ozangunalp ozangunalp commented Jun 26, 2025

QuarkusIntegrationTest and QuarkusMainIntegrationTest prepare dev services after determining the test profile and applying config overrides (using system properties).

Added QuarkusIntegrationTest to redis-devservices IT module and enabled integration test execution.

This comment has been minimized.

@ozangunalp
Copy link
Contributor Author

Rebasing after #48614

@ozangunalp
Copy link
Contributor Author

@alesj @brunobat The failure in integration-tests/observability-lgtm LgtmResourcesIT is related.
I can't understand what it is supposed to test.

For context, before getConfigOverrides in a profile were passed to the application, but NOT to the augmentation step to start dev services.

With this change config overrides are also "active" on custom augmentation to start dev services.

gsmet added a commit to gsmet/quarkus that referenced this pull request Jun 26, 2025
We enabled it for our Gradle tests but since then we have merged several
PRs that were failing.

The last occurrence is this PR:
- quarkusio#48614

And it caused failures as in:
- quarkusio#48627 (comment)

This comment has been minimized.

@ozangunalp ozangunalp force-pushed the redis_devservices_integration_tests branch from 04e7f63 to 770d2d8 Compare June 28, 2025 22:14

This comment has been minimized.

@ozangunalp
Copy link
Contributor Author

Failing opentelemetry tests are flaky, and I cannot reproduce the failing VertxVirtualThreadTest locally. I don't expect that they are related.

For the LgtmResourceIT I think we need to remove that test. Dev resources can't work with QuarkusIntegrationTest s because they rely on a custom runtime config source to create services at first config get (or property names get).

It did seemed like working before because the profile config wasn't read. So observability dev service was active, not the dev resource mechanism.

@holly-cummins
Copy link
Contributor

Failing opentelemetry tests are flaky, and I cannot reproduce the failing VertxVirtualThreadTest locally. I don't expect that they are related.

I agree.

For the LgtmResourceIT I think we need to remove that test. Dev resources can't work with QuarkusIntegrationTest s because they rely on a custom runtime config source to create services at first config get (or property names get).

It did seemed like working before because the profile config wasn't read. So observability dev service was active, not the dev resource mechanism.

Ohhh, that's so subtle! I wonder how often that happens. Often, I suspect. I had to work quite hard in the dev service tests to check the test was connected to the right one, and normal tests wouldn't necessarily do that. That might explain why this test is known to be flaky, though.

@ozangunalp
Copy link
Contributor Author

I wonder how often that happens.

This is only for LGTM Dev Resource, as it is the only dev resource implementation we've.

@brunobat
Copy link
Contributor

I'll let @alesj comment on this.

Comment on lines 6 to 7
//@Disabled
// TODO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove these two comments, right?

Comment on lines 168 to 175
<executions>
<execution>
<goals>
<goal>integration-test</goal>
<goal>verify</goal>
</goals>
</execution>
</executions>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see a more generic solution for this, so that we have consistent behaviour in integration tests rather than per-project adjustments to try and ensure integration tests run. But we may not be able to achieve that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this isn't the right way to get integration tests running; we only want them to run in native CIs. I've fixed and updated the native matrix instead.

@quarkus-bot quarkus-bot bot added the area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure label Jul 1, 2025
gsmet added a commit to gsmet/quarkus that referenced this pull request Jul 1, 2025
We enabled it for our Gradle tests but since then we have merged several
PRs that were failing.

The last occurrence is this PR:
- quarkusio#48614

And it caused failures as in:
- quarkusio#48627 (comment)

(cherry picked from commit b4ce66a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/testing triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration tests cannot use fixed port for dev services
3 participants