Skip to content

Update io.spring.dependency-management plugin version #48614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025

Conversation

Eng-Fouad
Copy link
Contributor

The old version 1.0.11.RELEASE uses a deprecated class org.gradle.api.tasks.Upload which will removed in Gradle 9.0.

The old version 1.0.11.RELEASE uses a deprecated class org.gradle.api.tasks.Upload which is removed in Gradle 9.0
@quarkus-bot quarkus-bot bot added the area/gradle Gradle label Jun 25, 2025
@Eng-Fouad Eng-Fouad mentioned this pull request Jun 25, 2025
10 tasks
Copy link

quarkus-bot bot commented Jun 25, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 09c5910.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ Gradle Tests - JDK 17

📦 integration-tests/gradle

io.quarkus.gradle.devmode.IncludedKotlinBuildDevModeTest.main - History

  • Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes.
	at app//org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at app//io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:164)
	at app//io.quarkus.gradle.devmode.QuarkusDevGradleTestBase.getHttpResponse(QuarkusDevGradleTestBase.java:165)

⚙️ Gradle Tests - JDK 17 Windows

📦 integration-tests/gradle

io.quarkus.gradle.devmode.IncludedKotlinBuildDevModeTest.main - History

  • Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes 30 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes  30 seconds.
	at app//org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at app//io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:164)
	at app//io.quarkus.gradle.devmode.QuarkusDevGradleTestBase.getHttpResponse(QuarkusDevGradleTestBase.java:165)

@geoand geoand merged commit 1fd4a78 into quarkusio:main Jun 26, 2025
21 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.25 - main milestone Jun 26, 2025
@Eng-Fouad Eng-Fouad deleted the gradle-deprecated-7 branch June 26, 2025 05:40
@geoand
Copy link
Contributor

geoand commented Jun 26, 2025

Unfortunately I am going to have to revert this as it is causing issues in CI (see here and here)

@Eng-Fouad
Copy link
Contributor Author

Unfortunately I am going to have to revert this as it is causing issues in CI (see here and here)

Sorry about that. I will try the first version (1.0.13.RELEASE) in which org.gradle.api.tasks.Upload was removed.

See: spring-gradle-plugins/dependency-management-plugin#337

@geoand
Copy link
Contributor

geoand commented Jun 26, 2025

No problem, the real issue is why our CI didn't catch the problem when you opened the PR

Eng-Fouad added a commit to Eng-Fouad/quarkus that referenced this pull request Jun 26, 2025
gsmet added a commit to gsmet/quarkus that referenced this pull request Jun 26, 2025
We enabled it for our Gradle tests but since then we have merged several
PRs that were failing.

The last occurrence is this PR:
- quarkusio#48614

And it caused failures as in:
- quarkusio#48627 (comment)
@Eng-Fouad
Copy link
Contributor Author

Eng-Fouad commented Jun 26, 2025

My bad. The version should've been:

id 'io.spring.dependency-management' version '1.1.7'

instead of:

id 'io.spring.dependency-management' version 'v1.1.7'

gsmet added a commit to gsmet/quarkus that referenced this pull request Jul 1, 2025
We enabled it for our Gradle tests but since then we have merged several
PRs that were failing.

The last occurrence is this PR:
- quarkusio#48614

And it caused failures as in:
- quarkusio#48627 (comment)

(cherry picked from commit b4ce66a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants