Skip to content

Remove deprecated functionality from smoke_test #4013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 7, 2025
Merged

Remove deprecated functionality from smoke_test #4013

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eec1f6b
Remove deprecated functionality from smoke_test
samanklesaria Aug 1, 2025
458bbe5
Remove smoke_test_no_ffmpeg
samanklesaria Aug 1, 2025
8f4164b
Add back parser argument for no-ffmpeg for backward compat
samanklesaria Aug 4, 2025
79e0971
Add back smoke_test_no_ffmpeg
samanklesaria Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 3 additions & 16 deletions test/smoke_test/smoke_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,28 +6,15 @@

def base_smoke_test():
import torchaudio # noqa: F401
import torchaudio.compliance.kaldi # noqa: F401
import torchaudio.datasets # noqa: F401
import torchaudio.functional # noqa: F401
import torchaudio.models # noqa: F401
import torchaudio.pipelines # noqa: F401
import torchaudio.sox_effects # noqa: F401
import torchaudio.transforms # noqa: F401
import torchaudio.utils # noqa: F401


def ffmpeg_test():
from torchaudio.io import StreamReader # noqa: F401


def _run_smoke_test(check_ffmpeg):
def _run_smoke_test():
base_smoke_test()

if not check_ffmpeg:
print("Skipping ffmpeg test.")
else:
ffmpeg_test()

print("Smoke test passed.")


Expand All @@ -38,13 +25,13 @@ def main(args=None) -> None:
logging.basicConfig(format="%(levelname)s: %(message)s", level=logging.DEBUG)

_chdir()
_run_smoke_test(options.ffmpeg)
_run_smoke_test()


def _parse_args(args):
parser = argparse.ArgumentParser()

# Warning: Please note this option should not be widely used, only use it when absolutely necessary
# Warning: Please note this option does nothing and only exists for backward compatibility.
parser.add_argument("--no-ffmpeg", dest="ffmpeg", action="store_false")
parser.add_argument("--debug", action="store_true", help="Enable debug logging.")

Expand Down
Loading