Skip to content

Remove deprecated functionality from smoke_test #4013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 7, 2025

Conversation

samanklesaria
Copy link
Collaborator

PLEASE NOTE THAT THE TORCHAUDIO REPOSITORY IS NO LONGER ACTIVELY MONITORED. You may not get a response. For open discussions, visit https://discuss.pytorch.org/.

@samanklesaria samanklesaria requested a review from a team as a code owner August 1, 2025 17:14
Copy link

pytorch-bot bot commented Aug 1, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4013

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 8 New Failures

As of commit 79e0971 with merge base 6519052 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed label Aug 1, 2025
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, approving to unblock but please see comments below before merging

@NicolasHug
Copy link
Member

Looks like the Windows wheel building jobs are failing with pytorch/audio/test/smoke_test/smoke_test_no_ffmpeg.py not found

I think it's because the scripts in pytorch/test-infra are still relying on it. Let's just put the file back (and forget about it forever)

@samanklesaria samanklesaria merged commit 89cf282 into main Aug 7, 2025
43 of 44 checks passed
@samanklesaria samanklesaria deleted the remove_smoke_test_deprecations branch August 7, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants