Skip to content

[Example] Layer Norm Forward #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: gh/PaulZhang12/1/base
Choose a base branch
from

Conversation

PaulZhang12
Copy link

@PaulZhang12 PaulZhang12 commented Jun 13, 2025

Stack from ghstack (oldest at bottom):

[ghstack-poisoned]
PaulZhang12 added a commit that referenced this pull request Jun 13, 2025
ghstack-source-id: ca3cb11
Pull Request resolved: #170
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jun 13, 2025
@@ -230,6 +236,7 @@ def convert_arg(arg: Node) -> TensorBox:
for n in nodes:
if "output_index" in n.meta:
output_nodes[n.meta["output_index"]] = n.name
import pdb; pdb.set_trace()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import pdb; pdb.set_trace()
breakpoint()

same thing but shorter.

PaulZhang12 added a commit that referenced this pull request Jun 13, 2025
ghstack-source-id: a9859b5
Pull Request resolved: #170
@PaulZhang12 PaulZhang12 reopened this Jun 13, 2025
PaulZhang12 added a commit that referenced this pull request Jul 21, 2025
ghstack-source-id: 44f54ae
Pull Request resolved: #170
@PaulZhang12 PaulZhang12 changed the title Layer Norm fwd issue [Example] Layer Norm Forward Jul 21, 2025
PaulZhang12 added a commit that referenced this pull request Jul 21, 2025
ghstack-source-id: f2dbcd0
Pull Request resolved: #170
PaulZhang12 added a commit that referenced this pull request Jul 21, 2025
ghstack-source-id: cb9208f
Pull Request resolved: #170
PaulZhang12 added a commit that referenced this pull request Jul 21, 2025
ghstack-source-id: b502c96
Pull Request resolved: #170
PaulZhang12 added a commit that referenced this pull request Jul 21, 2025
ghstack-source-id: c204f75
Pull Request resolved: #170
PaulZhang12 added a commit that referenced this pull request Jul 21, 2025
ghstack-source-id: f8645d6
Pull Request resolved: #170


if __name__ == "__main__":
main()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw probably need to add a unit test to test_examples.py similar to other examples

PaulZhang12 added a commit that referenced this pull request Jul 21, 2025
ghstack-source-id: 99c27eb
Pull Request resolved: #170
PaulZhang12 added a commit that referenced this pull request Jul 21, 2025
ghstack-source-id: 565ab39
Pull Request resolved: #170
PaulZhang12 added a commit that referenced this pull request Jul 21, 2025
ghstack-source-id: 38636cd
Pull Request resolved: #170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants