Improved minimum_cell_size calculation#10
Open
psheehan wants to merge 2 commits into
Open
Conversation
…stance across a cell in all three directions.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
==========================================
+ Coverage 88.82% 88.87% +0.04%
==========================================
Files 11 11
Lines 2220 2229 +9
==========================================
+ Hits 1972 1981 +9
Misses 248 248 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code used to use volume**1/3 to determine the minumum cell size for sub-pixeling, and this worked fine for fully three dimensional grids, but for 2D axisymmetric grids the axisymmetric-ness of it made the cell very large in the phi direction. This PR updates the code to explicitly calculate the "average" distance across each cell in each dimension, and takes the minimum value as the minimum cell size.