Skip to content

Disk bugfixes#13

Merged
psheehan merged 3 commits into
mainfrom
disk_bugfixes
Jun 8, 2026
Merged

Disk bugfixes#13
psheehan merged 3 commits into
mainfrom
disk_bugfixes

Conversation

@bdrechsler

Copy link
Copy Markdown
Collaborator

Commented out the subpixeling for now.
Fixed issue with physical pixel size.
Fixed vertical bars in images by rounding to the nearest integer.

@codecov-commenter

codecov-commenter commented Jun 4, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.13%. Comparing base (6294acc) to head (9aea699).
⚠️ Report is 27 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   88.82%   90.13%   +1.30%     
==========================================
  Files          11       11              
  Lines        2220     2362     +142     
==========================================
+ Hits         1972     2129     +157     
+ Misses        248      233      -15     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@psheehan

psheehan commented Jun 5, 2026

Copy link
Copy Markdown
Owner

Overall looks good and tests are passing! I think my only note is that I would be inclined to not turn off the sub-pixeling. I think #10 should fix it and since that is imminent, we might as well just confirm and merge.

@psheehan psheehan merged commit b8c6d50 into main Jun 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants