Close slice S3: acceptance verified, records updated, handover brief - #157
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
Acceptance verified against source and the merged PRs; the spec gains a Close-out section recording the two items that shipped amended (the bin's Node floor is 22.18, not 24, via composer #224; ledger Q2 was ruled dropped rather than closed by S3's mechanism). plan.md marks S3 closed and points at S8 as next. deferred.md gains the isCI item from the handover brief: composer drops its ci-info answer at its next engine-pin bump, because prisma-cli #155 made the engine detect CI itself. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
|
Warning Review limit reached
Next review available in: 18 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
Records only — no code. Follows the S3 close-out precedent (#157). ## What this records The S7 contract's seven acceptance items verified against source, merged PRs (#164, #166), two dry-run dispatches, and the registry: `@prisma/cli@8.0.0-rc.1` and `@prisma/cli-engine@8.0.0-rc.1` are live under `next`, `latest` untouched — the project DoD's artifact exists, published by the operator's own action. The Close-out section in `specs/s7-release.md` records the evidence per acceptance item, the two incidents from the first real publish (npm's trusted publisher still naming the deleted `publish-cli.yml`; the immutable Release freezing assetless before its upload) with their dispositions, and the one deliberately amended item: "Release with tarballs attached" holds from #166 onward, not for `v8.0.0-rc.1` itself. `plan.md` marks the slice closed. `deferred.md` gains the offered-but-undecided publish-script extraction. ## Out of scope here The S5 cutover (brief in #167, dispatched elsewhere), S2d and S6 (both dispatched elsewhere), S9. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2 participants
Records only — no code changes.
Slice S3 (Composer adoption) shipped across eight PRs in the two repos, the last being the mount (#152) here and prisma/composer#226 there. This PR closes it formally:
.drive/projects/prisma-cli-v8/specs/s3-composer.md— acceptance list ticked, with a Close-out section recording the evidence per item and the two items that shipped amended rather than as written: the published bin's Node floor is>=22.18.0, not>=24(composer #224 dropped composer's own floor; the max-wins rule held, the number moved), and the "ledger Q2 closes 'mechanism built in S3'" line was superseded whenservice runwas dropped..drive/projects/prisma-cli-v8/plan.md— S3 marked closed; next slice by the dependency graph is S8 (design first)..drive/projects/prisma-cli-v8/deferred.md— gains one item: composer drops itsisCIanswer and theci-infodependency at its next engine-pin bump, since The engine works out whether it is in CI, instead of asking every host #155 made the engine detect CI itself..drive/projects/prisma-cli-v8/assets/briefs/s3-closeout-handover.md— the handover brief for an agent with no prior context (already on this branch).🤖 Generated with Claude Code