Skip to content

Close slice S7: acceptance verified, records updated - #168

Merged
wmadden merged 1 commit into
mainfrom
s7-closeout
Aug 12, 2026
Merged

Close slice S7: acceptance verified, records updated#168
wmadden merged 1 commit into
mainfrom
s7-closeout

Conversation

@wmadden-electric

Copy link
Copy Markdown
Contributor

Records only — no code. Follows the S3 close-out precedent (#157).

What this records

The S7 contract's seven acceptance items verified against source, merged PRs (#164, #166), two dry-run dispatches, and the registry: @prisma/cli@8.0.0-rc.1 and @prisma/cli-engine@8.0.0-rc.1 are live under next, latest untouched — the project DoD's artifact exists, published by the operator's own action.

The Close-out section in specs/s7-release.md records the evidence per acceptance item, the two incidents from the first real publish (npm's trusted publisher still naming the deleted publish-cli.yml; the immutable Release freezing assetless before its upload) with their dispositions, and the one deliberately amended item: "Release with tarballs attached" holds from #166 onward, not for v8.0.0-rc.1 itself. plan.md marks the slice closed. deferred.md gains the offered-but-undecided publish-script extraction.

Out of scope here

The S5 cutover (brief in #167, dispatched elsewhere), S2d and S6 (both dispatched elsewhere), S9.

🤖 Generated with Claude Code

The contract's seven acceptance items check off against source,
merged PRs (#164, #166), two dry-run dispatches, and the registry
itself - the operator's first real publish put both packages on npm
under next the same day. The Close-out section records the evidence
per item, the two publish incidents (the stale trusted-publisher
workflow name; the immutable Release freezing assetless) and their
dispositions, and the one deliberately amended item: Release assets
hold from #166 onward, not for v8.0.0-rc.1 itself. plan.md marks the
slice closed; deferred.md gains the publish-script extraction entry.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: willbot <w.a.madden+machine@gmail.com>
Signed-off-by: Will Madden <madden@prisma.io>
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@wmadden-electric, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 30 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: bdbce6bb-df57-41e5-b422-620f3c054963

📥 Commits

Reviewing files that changed from the base of the PR and between 94fdac2 and 287cd8c.

📒 Files selected for processing (3)
  • .drive/projects/prisma-cli-v8/deferred.md
  • .drive/projects/prisma-cli-v8/plan.md
  • .drive/projects/prisma-cli-v8/specs/s7-release.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Aug 12, 2026

Copy link
Copy Markdown

Open in StackBlitz

npx https://pkg.pr.new/@prisma/cli@168
npx https://pkg.pr.new/@prisma/cli-engine@168

commit: 287cd8c

@wmadden
wmadden merged commit 0c22bde into main Aug 12, 2026
13 checks passed
@wmadden
wmadden deleted the s7-closeout branch August 12, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants