Skip to content

Conversation

@geofjamg
Copy link
Member

@geofjamg geofjamg commented Sep 3, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

geofjamg and others added 30 commits March 16, 2025 20:52
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@geofjamg
Copy link
Member Author

Hello, I am the author of PyOptInterface.

Thanks for your interests in PyOptInterface (POI) as the modeling tool for OPF.

I notice that you are using the old NLP interface in previous version of POI, and I recommend using the more intuitive interface we designed in POI v0.5.0, where you can declare nonlinear constraint directly without specifying function in advance. You can refer to the NLP interface and the ACOPF example.

If you have any questions for the usage of POI, welcome to open a thread in Discussion of POI repo or ping me here.

Hi,
I migrated to 0.5.0.
Thanks for this amazing project!

geofjamg and others added 22 commits September 21, 2025 22:14
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
# Conflicts:
#	java/pypowsybl/src/main/java/com/powsybl/dataframe/network/extensions/VoltageRegulationDataframeAdder.java
#	java/pypowsybl/src/main/java/com/powsybl/dataframe/network/extensions/VoltageRegulationDataframeProvider.java
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
# Conflicts:
#	java/pypowsybl/src/main/java/com/powsybl/dataframe/network/extensions/VoltageRegulationDataframeAdder.java
#	java/pypowsybl/src/main/java/com/powsybl/dataframe/network/extensions/VoltageRegulationDataframeProvider.java
#	tests/test_network_extensions.py
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
# Conflicts:
#	java/pypowsybl/src/main/java/com/powsybl/dataframe/network/extensions/VoltageRegulationDataframeAdder.java
#	java/pypowsybl/src/main/java/com/powsybl/dataframe/network/extensions/VoltageRegulationDataframeProvider.java
#	tests/test_network_extensions.py
# Conflicts:
#	tests/test_network_extensions.py
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
closed_branch_nums = []
open_side1_branch_nums = []
open_side2_branch_nums = []
branch_count = len(network_cache.lines) + len(network_cache.transformers_2w)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why branch_count is not defined as branch_count = len(network_cache.branches) ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can, this is equivalent

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants