Reduce time spent in eval and der in equation resolution #1174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
vidaldid-rte
force-pushed
the
investig_vect_and_lazy
branch
from
cb70dd0 to
4e8d7d8
Compare
This reverts commit de7359f. Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
vidaldid-rte
force-pushed
the
investig_vect_and_lazy
branch
from
068ec85 to
51e9ef7
Compare
|
Signed-off-by: Didier Vidal <[email protected]>
5 tasks
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
vidaldid-rte
force-pushed
the
investig_vect_and_lazy
branch
from
ec914b3 to
6484c01
Compare
|
vidaldid-rte
changed the title
|
Signed-off-by: Didier Vidal <[email protected]>
src/main/java/com/powsybl/openloadflow/ac/equations/AbstractBranchAcFlowEquationTerm.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/openloadflow/ac/equations/AbstractClosedBranchAcFlowEquationTerm.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/openloadflow/ac/equations/vector/AcVectorEngine.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/openloadflow/ac/equations/vector/AcVectorEngine.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/openloadflow/ac/equations/vector/AcVectorEngine.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/openloadflow/ac/equations/vector/AcVectorEngine.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/openloadflow/ac/equations/vector/AcVectorEngine.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Didier Vidal <[email protected]>
…riables Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
6 tasks
| : EquationTermEventType.EQUATION_TERM_DEACTIVATED); | ||
| // TODO: Remove the trace | ||
| if (getVectorIndex() == 0) { | ||
| System.out.println(Thread.currentThread().getName() + " Active Status " + getClass().getSimpleName() + " " + getVectorIndex() + " " + active); |
| } | ||
| return null; | ||
| // TODO return for eval | ||
| // acVectorEngine.vecToP2[element.getNum()] = ClosedBranchSide2ActiveFlowEquationTerm::vec2p2;} |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the idea of #778 (that is minimizing memory cache misses during equation eval and der) in a way that is compatible with the current equation model and that keeps its properties (code isolation, lazy evaluation when done outside of NR, object model).
Results
Computation time divided by 1.8
Der and eval are no longer the top hotspot in a Security Analysis
Before:
With the PR:
Implementation
A VectorEngine is in charge of computing eval and der used in the NR resolution.
The optimization is performed on branch equations.
To minimize cache misses, the terms are sorted element type, element num (which is most often a branch), equation element num (wich is most often a bus), then by bus, then by variable (for der operations).
Branch data is stored in a unique array ordered by branch num.
To avoid loading small objects (like terms and equations), their active status and equation columns are replicated via the notification system in an ordered array.
Some terms provide static interfaces called VecToVal that enable to compute derivatives or evalLhs without loading the term object. This is done at this time for close branch equations on P and Q.
Branch typical values (sinksi, costhetha1, costheta2 etc..) are computed only once per branch.
Known issues
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: