-
Notifications
You must be signed in to change notification settings - Fork 11
Improve PR #1174 (Reduce time spent in eval and der in equation resolution) #1281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: investig_vect_and_lazy
Are you sure you want to change the base?
Improve PR #1174 (Reduce time spent in eval and der in equation resolution) #1281
Conversation
Signed-off-by: PRABAKARAN Sylvestre <[email protected]>
Signed-off-by: PRABAKARAN Sylvestre <[email protected]>
Signed-off-by: PRABAKARAN Sylvestre <[email protected]>
Signed-off-by: PRABAKARAN Sylvestre <[email protected]>
Signed-off-by: PRABAKARAN Sylvestre <[email protected]>
Signed-off-by: PRABAKARAN Sylvestre <[email protected]>
Signed-off-by: PRABAKARAN Sylvestre <[email protected]>
Signed-off-by: PRABAKARAN Sylvestre <[email protected]>
Signed-off-by: PRABAKARAN Sylvestre <[email protected]>
Signed-off-by: PRABAKARAN Sylvestre <[email protected]>
Signed-off-by: PRABAKARAN Sylvestre <[email protected]>
Signed-off-by: PRABAKARAN Sylvestre <[email protected]>
Signed-off-by: PRABAKARAN Sylvestre <[email protected]>
| acVectorEngine.y[branchNum] = piModel.getY(); | ||
| acVectorEngine.ksi[branchNum] = piModel.getKsi(); | ||
| acVectorEngine.sinKsi[branchNum] = FastMath.sin(piModel.getKsi()); | ||
| acVectorEngine.cosKsi[branchNum] = FastMath.cos(piModel.getKsi()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing wrong with your PR.
But I realise that those field may depend on the tap for transformers with tap changer capabilities.
The fields are final in the main branch.
But it seems their is a bug here. They should be updated when a tap changes. Maybe to handle in a separate PR...
That wille be easier once we have centralized them.
Signed-off-by: PRABAKARAN Sylvestre <[email protected]>
src/main/java/com/powsybl/openloadflow/ac/equations/vector/AcVectorEngine.java
Show resolved
Hide resolved
|



What kind of change does this PR introduce?
Optimization propsoed to improve PR #1174 (these modifications aims at being merged on the corresponding branch)
3 main improvements proposed :
-> Tested for some country networks : this improves 4 to 5 % time spent to compute an AC Security Analysis