Skip to content

try escaping output and search paths #2175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

try escaping output and search paths #2175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions Source/Heavy/ExporterBase.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ struct ExporterBase : public Component
void startExport(File const& outDir)
{
auto patchPath = patchFile.getFullPathName();
auto const& outPath = outDir.getFullPathName();
auto const& outPath = "\"" + outDir.getFullPathName() + "\"";
auto projectTitle = projectNameValue.toString();
auto projectCopyright = projectCopyrightValue.toString();

Expand All @@ -140,7 +140,7 @@ struct ExporterBase : public Component
}

// Add original file location to search paths
auto searchPaths = StringArray { realPatchFile.getParentDirectory().getFullPathName() };
auto searchPaths = StringArray { "\"" + realPatchFile.getParentDirectory().getFullPathName() + "\""};

editor->pd->setThis();

Expand All @@ -149,12 +149,8 @@ struct ExporterBase : public Component
int numItems;
pd::Interface::getSearchPaths(paths, &numItems);

if (realPatchFile.existsAsFile()) {
searchPaths.add(realPatchFile.getParentDirectory().getFullPathName());
}

for (int i = 0; i < numItems; i++) {
searchPaths.add(paths[i]);
searchPaths.add("\"" + String(paths[i]) + "\"");
}

// Make sure we don't add the file location twice
Expand Down