Skip to content

tidb: add description about GB18030 #18662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

CbcWestwolf
Copy link
Member

@CbcWestwolf CbcWestwolf commented Sep 19, 2024

What is changed, added or deleted? (Required)

Add description about GB18030

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 19, 2024
@lilin90 lilin90 self-assigned this Sep 20, 2024
@lilin90 lilin90 added v8.4 This PR/issue applies to TiDB v8.4. translation/doing This PR’s assignee is translating this PR. labels Sep 20, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Sep 20, 2024
@lilin90 lilin90 requested review from lilin90 and hfxsd September 23, 2024 03:52
@lilin90 lilin90 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 23, 2024
Copy link

ti-chi-bot bot commented Sep 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-23 13:32:44.88699319 +0000 UTC m=+1486434.627417141: ☑️ agreed by hfxsd.

@lilin90 lilin90 removed the v8.4 This PR/issue applies to TiDB v8.4. label Oct 8, 2024
@shawn0915
Copy link
Contributor

@CbcWestwolf 请问这里的GB18030是指 GB 18030-2022 么?

@CbcWestwolf
Copy link
Member Author

CbcWestwolf commented Oct 30, 2024

请问这里的GB18030是指 GB 18030-2022 么?

是的 @shawn0915

@shawn0915
Copy link
Contributor

请问这里的GB18030是指 GB 18030-2022 么?

是的 @shawn0915

这是之前企业版支持的特性?要不要明确说明一下是 GB 18030-2022 毕竟跟老国标是有区别的。

@lilin90 lilin90 added the v9.0-beta.1 This PR/issue applies to TiDB v9.0-beta.1. label Dec 30, 2024
@lilin90 lilin90 requested a review from Benjamin2037 December 30, 2024 06:46
@lilin90
Copy link
Member

lilin90 commented Dec 30, 2024

@CbcWestwolf Would you please update the corresponding descriptions in this PR from v8.4 to v9.0, and add description about #18662 (comment)?

@lilin90 lilin90 requested a review from hfxsd December 30, 2024 09:40
@CbcWestwolf
Copy link
Member Author

@lilin90 Sure, let me update it after merging the code.

@lilin90 lilin90 removed their assignment Jan 6, 2025
Copy link

ti-chi-bot bot commented Jan 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hfxsd, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hfxsd hfxsd requested a review from Frank945946 January 13, 2025 01:54
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 10, 2025
@CbcWestwolf
Copy link
Member Author

/retest

@lilin90 lilin90 added v9.0-beta.2 This PR/issue applies to TiDB v9.0-beta.2. and removed v9.0-beta.1 This PR/issue applies to TiDB v9.0-beta.1. labels Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/doing This PR’s assignee is translating this PR. v9.0-beta.2 This PR/issue applies to TiDB v9.0-beta.2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants