-
Notifications
You must be signed in to change notification settings - Fork 1.2k
tidb: add description about GB18030 #18662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[LGTM Timeline notifier]Timeline:
|
@CbcWestwolf 请问这里的GB18030是指 GB 18030-2022 么? |
是的 @shawn0915 |
这是之前企业版支持的特性?要不要明确说明一下是 |
@CbcWestwolf Would you please update the corresponding descriptions in this PR from v8.4 to v9.0, and add description about #18662 (comment)? |
@lilin90 Sure, let me update it after merging the code. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: xixirangrang <[email protected]>
Co-authored-by: Lilian Lee <[email protected]>
/retest |
What is changed, added or deleted? (Required)
Add description about GB18030
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
GB18030
and 2 collations tikv/tikv#17467 and charset,collation: implementGB18030
and 2 collations | tidb-test=pr/2087 tidb#55792 are mergedDo your changes match any of the following descriptions?