Skip to content

Character set and collation updates #19976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 14, 2025
Merged

Character set and collation updates #19976

merged 8 commits into from
Jan 14, 2025

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Jan 13, 2025 •
edited
Loading

What is changed, added or deleted? (Required)

  • Update output of SHOW COLLATION
  • Add collation nameing details
  • Update utf8/utf8mb3 info

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

Note that Pad_attribute is in v8.5 and newer, so don't backport to older versions. See also pingcap/tidb#54282

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Might conflict with changes from pingcap/docs-cn#18662

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 13, 2025
@hfxsd hfxsd added the translation/doing This PR's assignee is translating this PR. label Jan 13, 2025
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jan 13, 2025
@hfxsd hfxsd added missing-translation-status This PR does not have translation status info. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Jan 13, 2025
@hfxsd hfxsd self-assigned this Jan 13, 2025
@hfxsd hfxsd removed the missing-translation-status This PR does not have translation status info. label Jan 13, 2025
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 13, 2025
hfxsd
hfxsd reviewed Jan 13, 2025
View reviewed changes
hfxsd
hfxsd reviewed Jan 13, 2025
View reviewed changes
hfxsd
hfxsd reviewed Jan 13, 2025
View reviewed changes
hfxsd
hfxsd reviewed Jan 13, 2025
View reviewed changes
dveeden and others added 2 commits January 13, 2025 15:24
@hfxsd hfxsd mentioned this pull request Jan 13, 2025
Merged
15 tasks
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Jan 13, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 13, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 14, 2025

@CbcWestwolf: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jolynejo
Copy link

/lgtm

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 14, 2025

@jolynejo: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 14, 2025

@jolynejo: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hfxsd hfxsd requested review from qiancai and removed request for lilin90 January 14, 2025 02:45
qiancai
qiancai approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 14, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 14, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-13 14:58:50.518573556 +0000 UTC m=+797673.807405275: ☑️ agreed by hfxsd.
  • 2025-01-14 06:43:44.234664712 +0000 UTC m=+14495.689710861: ☑️ agreed by qiancai.

@hfxsd
Copy link
Collaborator

hfxsd commented Jan 14, 2025

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 14, 2025
@ti-chi-bot ti-chi-bot bot merged commit a7a5ac7 into pingcap:master Jan 14, 2025
9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #19986.

This was referenced Jan 14, 2025
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Jan 14, 2025
@ti-chi-bot
Character set and collation updates (#19976) (#19986)
21711e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CbcWestwolf CbcWestwolf CbcWestwolf approved these changes

@hfxsd hfxsd hfxsd approved these changes

@qiancai qiancai qiancai approved these changes

@jolynejo jolynejo jolynejo approved these changes

@Benjamin2037 Benjamin2037 Awaiting requested review from Benjamin2037

Assignees

@hfxsd hfxsd

Labels
approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dveeden @jolynejo @hfxsd @ti-chi-bot @CbcWestwolf @qiancai