placeholder metrics가 carry를 존중 - #5222
Open
dolsup wants to merge 1 commit into
Open
Conversation
This was referenced Aug 7, 2026
Open
Contributor
Author
There was a problem hiding this comment.
Reviewed the changes to how placeholder metrics resolve modifiers (now via the shared resolve_caret_modifiers instead of duplicating logic off NodeView::effective()). Verified that Alignment still resolves correctly through the new caret-based path (non-inheritable, resolved via ancestor paragraph match) and that the refactor compiles cleanly (deref coercions, Copy types). No bugs, logic errors, or security issues found.
dolsup
force-pushed
the
fix/palceholder-metrics
branch
from
August 8, 2026 06:39
d0cf7c1 to
03deeff
Compare
This was referenced Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

caret의 로직을 재사용함