Skip to content

placeholder metrics가 carry를 존중 - #5222

Open
dolsup wants to merge 1 commit into
fix/clear-carryfrom
fix/palceholder-metrics
Open

placeholder metrics가 carry를 존중#5222
dolsup wants to merge 1 commit into
fix/clear-carryfrom
fix/palceholder-metrics

Conversation

@dolsup

@dolsup dolsup commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

caret의 로직을 재사용함

dolsup commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label 🚀 to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dolsup
dolsup marked this pull request as ready for review August 7, 2026 14:43
@dolsup
dolsup requested a review from devunt as a code owner August 7, 2026 14:43

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the changes to how placeholder metrics resolve modifiers (now via the shared resolve_caret_modifiers instead of duplicating logic off NodeView::effective()). Verified that Alignment still resolves correctly through the new caret-based path (non-inheritable, resolved via ancestor paragraph match) and that the refactor compiles cleanly (deref coercions, Copy types). No bugs, logic errors, or security issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant