Skip to content

안드로이드 에디터 찾기 인풋에서 조합 깨지는 문제 수정 - #5216

Open
dolsup wants to merge 1 commit into
fix/app-navigation-keyboard-pop-commitfrom
fix/app-editor-find-input-composition
Open

안드로이드 에디터 찾기 인풋에서 조합 깨지는 문제 수정#5216
dolsup wants to merge 1 commit into
fix/app-navigation-keyboard-pop-commitfrom
fix/app-editor-find-input-composition

Conversation

@dolsup

@dolsup dolsup commented Aug 7, 2026

Copy link
Copy Markdown
Contributor
  • 찾기 입력 상태를 에디터 화면에서 소유하고 top bar에서는 렌더링만 하도록 변경
  • 세션 검색어 반영이 늦더라도 로컬 IME 조합 범위가 유지되도록 수정
  • ㅇ → 아 한글 조합 회귀 테스트 추가

@dolsup
dolsup marked this pull request as ready for review August 7, 2026 09:45

dolsup commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label 🚀 to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dolsup
dolsup force-pushed the fix/app-navigation-keyboard-pop-commit branch from 1067330 to 93ffae2 Compare August 7, 2026 11:58
@dolsup
dolsup force-pushed the fix/app-editor-find-input-composition branch from 8ef8fc0 to 9350cf8 Compare August 7, 2026 11:58

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the changes to fix Korean IME composition breaking in the Android editor find input. The fix correctly wraps the value read in Snapshot.withoutReadObservation in TextInputState.update() to prevent the recompose scope from re-subscribing to session state changes mid-composition, and moves rememberTextInputState ownership up to EditorScreen (a valid composable context) so the top bar only renders it. A regression test covering the ㅇ → 아 composition case was added. No bugs, logic errors, or security issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant