Type integration test responses#241
Closed
ethayu wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #240\nPart of #201\nStacked on #239\n\n## Summary\n- widen fake HTTP client payload annotations to match test payload shapes\n- cast dynamic service response dictionaries at assertion boundaries\n- type captured monkeypatch call data as dynamic test data\n\n## Verification\n- source /opt/ros/humble/setup.bash && source /home/ubuntu/monorepo/controls/sae_2025_ws/install/setup.bash && npx --yes pyright controls/sae_2025_ws/src/integration/test/test_deploy.py controls/sae_2025_ws/src/integration/test/test_discovery.py controls/sae_2025_ws/src/integration/test/test_api_contract.py controls/sae_2025_ws/src/integration/test/test_config.py --outputjson\n- ruff format --config controls/sae_2025_ws/.ruff.toml controls/sae_2025_ws/src/integration/test/test_deploy.py controls/sae_2025_ws/src/integration/test/test_api_contract.py\n- ruff check --config controls/sae_2025_ws/.ruff.toml controls/sae_2025_ws/src/integration/test/test_deploy.py controls/sae_2025_ws/src/integration/test/test_api_contract.py\n- python3 -m pytest -q controls/sae_2025_ws/src/integration/test/test_deploy.py controls/sae_2025_ws/src/integration/test/test_api_contract.py