Skip to content

Double the default tool round limit #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paoloanzn merged 1 commit into from
Aug 6, 2026
Merged

Double the default tool round limit #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ namespace microcodex {
std::string reasoning_effort = "medium";
std::string endpoint = "https://chatgpt.com/backend-api/codex/responses";
long idle_timeout_seconds = 300;
std::size_t maximum_tool_rounds = 64;
std::size_t maximum_tool_rounds = 128;
std::size_t maximum_parallel_tool_calls = 32;
std::size_t maximum_tool_output_bytes = 64 * 1024;
// Offline fallback matching Codex's 272K unknown-model descriptor. The
Expand Down
2 changes: 1 addition & 1 deletion tests/005-interruption.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,6 @@ STDOUT
STDERR

expect_process "T5.6: the tool round limited turn is persisted" 0 \
grep -q 'call_round_64' "$tool_limit_home"/conversations/*.jsonl <<'STDOUT' 3<<'STDERR'
grep -q 'call_round_128' "$tool_limit_home"/conversations/*.jsonl <<'STDOUT' 3<<'STDERR'
STDOUT
STDERR
18 changes: 10 additions & 8 deletions tests/mock-server.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

MAX_REQUEST_BYTES = 1024 * 1024
REQUEST_TIMEOUT = 10
TOOL_ROUND_LIMIT = 128

def assert(condition, message)
raise message unless condition
Expand Down Expand Up @@ -175,7 +176,7 @@ def validate_scenario!(scenario, request_number, payload)
if request_number.zero?
assert(input_text(payload) == "Start tool round limit test",
"tool round limit scenario did not receive its first prompt")
elsif request_number <= 64
elsif request_number <= TOOL_ROUND_LIMIT
previous_call_id = "call_round_#{request_number - 1}"
assert(input.any? { |item| item["type"] == "function_call" &&
item["call_id"] == previous_call_id },
Expand All @@ -184,11 +185,12 @@ def validate_scenario!(scenario, request_number, payload)
item["call_id"] == previous_call_id },
"tool round request lost the previous function output")
else
over_limit_call_id = "call_round_#{TOOL_ROUND_LIMIT}"
assert(input.any? { |item| item["type"] == "function_call" &&
item["call_id"] == "call_round_64" },
item["call_id"] == over_limit_call_id },
"continued request lost the over-limit function call")
skipped = input.find do |item|
item["type"] == "function_call_output" && item["call_id"] == "call_round_64"
item["type"] == "function_call_output" && item["call_id"] == over_limit_call_id
end
assert(skipped && skipped.fetch("output").include?("was not executed"),
"over-limit function call was not paired with a non-execution output")
Expand Down Expand Up @@ -420,8 +422,8 @@ def response_for(scenario, request_number)
message_response("Continued limited answer")
[200, "OK", "text/event-stream", body]
when "tool-round-limit"
body = request_number <= 64 ? round_limit_call_response(request_number) :
message_response("Continued after tool round limit")
body = request_number <= TOOL_ROUND_LIMIT ? round_limit_call_response(request_number) :
message_response("Continued after tool round limit")
[200, "OK", "text/event-stream", body]
when "interrupt-output"
[200, "OK", "text/event-stream", message_response("Continued partial answer")]
Expand Down Expand Up @@ -488,7 +490,7 @@ def send_response(socket, status, reason, content_type, body)
expected_requests = if scenario == "context-error-retry"
3
elsif scenario == "tool-round-limit"
66
TOOL_ROUND_LIMIT + 2
elsif %w[tool-write tool-edit tool-shell-env tool-bash-denied compaction-resume incomplete-output interrupt-output interrupt-tool].include?(scenario)
2
else
Expand Down Expand Up @@ -544,9 +546,9 @@ def send_response(socket, status, reason, content_type, body)
File.write(File.join(request_directory, "interrupt-ready"), "ready\n")
elsif scenario == "incomplete-output" && request_number.zero?
File.write(File.join(request_directory, "incomplete-ready"), "ready\n")
elsif scenario == "tool-round-limit" && request_number == 64
elsif scenario == "tool-round-limit" && request_number == TOOL_ROUND_LIMIT
File.write(File.join(request_directory, "limit-ready"), "ready\n")
elsif scenario == "tool-round-limit" && request_number == 65
elsif scenario == "tool-round-limit" && request_number == TOOL_ROUND_LIMIT + 1
File.write(File.join(request_directory, "continued"), "continued\n")
elsif %w[incomplete-output interrupt-output interrupt-tool].include?(scenario) && request_number == 1
File.write(File.join(request_directory, "continued"), "continued\n")
Expand Down